From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST v6 12/24] distros: Support pvgrub for
	Wheezy too.
Date: Tue, 12 May 2015 16:49:36 +0100
Message-ID: <1431445776.8263.190.camel@citrix.com>
References: <1430905605.2660.187.camel@citrix.com>
	<1430906213-30108-12-git-send-email-ian.campbell@citrix.com>
	<21842.7600.936737.546545@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21842.7600.936737.546545@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-05-12 at 16:35 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[OSSTEST v6 12/24] distros: Support pvgrub for Wheezy too."):
> > This requires us to install pv-grub-menu from backports, which we do
> > using a late_command.
> ...
> > +#    $preseed .= <<END if $extra_packages =~ m#\b/$suite-backports\b#;
> 
> This is quite odd.  It expects the _suite_ name in $extra_packages.
> But AFAICT nothing ever passes that anyway.

It was checking for uses of "$package/$suite-backports" which is a
syntax supported by apt (and hence d-i) for installing things from the
non-default suite.

I think that functionality isn't actually used any more, because it
didn't actually work in the d-i context (I've forgotten why) and so we
do it via a late_command now instead (later in this patch).

So I think I should ditch that whole bit.

Ian.