From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST v6 15/24] distros: add branch
	infrastructure
Date: Wed, 13 May 2015 10:12:23 +0100
Message-ID: <1431508343.8263.223.camel@citrix.com>
References: <1430905605.2660.187.camel@citrix.com>
	<1430906213-30108-15-git-send-email-ian.campbell@citrix.com>
	<21842.9324.594798.641061@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21842.9324.594798.641061@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-05-12 at 17:03 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[OSSTEST v6 15/24] distros: add branch infrastructure"):
> > Since the distro nightlies are not version controlled we cannot use
> > the usual mechanisms for detecting regressions. Special case things
> > appropriately. We use an OLD_REVISION of "flight-NNN" to signify that
> > the old revision is another flight and not a tree revision.
> 
> This all looks pretty good, except:
> 
> > -if grep -xF $NEW_REVISION $branch.force-rev; then push=$OSSTEST_PUSH; fi
> > +if test -n "$NEW_REVISION" && grep -xF $NEW_REVISION $branch.force-rev; then push=$OSSTEST_PUSH; fi
> 
> Why is it not sufficient to simply add " " around $NEW_REVISION ?

Uh, I think it is!