From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST v6 13/24] distros: support PV guest
 install from Debian netinst media.
Date: Wed, 13 May 2015 10:16:33 +0100
Message-ID: <1431508593.8263.227.camel@citrix.com>
References: <1430905605.2660.187.camel@citrix.com>
	<1430906213-30108-13-git-send-email-ian.campbell@citrix.com>
	<21842.8616.482657.154030@mariner.uk.xensource.com>
	<21842.9982.377958.717026@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21842.9982.377958.717026@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-05-12 at 17:14 +0100, Ian Jackson wrote:
> Ian Jackson writes ("Re: [OSSTEST v6 13/24] distros: support PV guest install from Debian netinst media."):
> > Ian Campbell writes ("[OSSTEST v6 13/24] distros: support PV guest install from Debian netinst media."):
> > > +    my $baseurl = $cd eq "current" ?
> > > +      "http://cdimage.debian.org/debian-cd/current/$props->{PathArch}/jigdo-cd" :
> > > +      "http://cdimage.debian.org/cdimage/weekly-builds/$props->{PathArch}/jigdo-cd";
> > 
> > This should surely come from a runvar (or perhaps a config option)
> > rather than being hardcoded.
> 
> It occurs to me that doing this in a runvar with the url would mean
> that the runvar "<GUEST>_cd" which currently contains a string like
> `current' would go away.

If you prefer, sure.

> I wonder if a similar consideration ought to apply to the
> `<GUEST>_diver' thing.  (Why `diver' rather than `divert', JOOI?)

It diver for debian-installer version (cf TftpDiVersion).

It can either be "osstest", which means "use $c{TftpDiVersion}" (i.e.
the same version as host installs use, updated with
mg-update-debian-installer) or it can be "daily", meaning the daily
images from [0] or a string which is any directory entry in [1], most
commonly "current" (and not many historical versions are kept there by
Debian).

Ian.

[0] http://d-i.debian.org/daily-images/$arch/daily/netboot
[1] ftp://ftp.debian.org/debian/dists/wheezy/main/installer-amd64/