From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4] OSSTEST: introduce a raisin build test
Date: Wed, 13 May 2015 12:57:30 +0100
Message-ID: <1431518250.8263.254.camel@citrix.com>
References: <1431422408-16659-1-git-send-email-stefano.stabellini@eu.citrix.com>
	<1431425547.8263.127.camel@citrix.com>
	<alpine.DEB.2.02.1505121202050.20496@kaball.uk.xensource.com>
	<1431430431.8263.143.camel@citrix.com>
	<alpine.DEB.2.02.1505121243010.20496@kaball.uk.xensource.com>
	<1431507683.8263.212.camel@citrix.com>
	<alpine.DEB.2.02.1505131247430.20496@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1505131247430.20496@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-05-13 at 12:48 +0100, Stefano Stabellini wrote:
> On Wed, 13 May 2015, Ian Campbell wrote:
> > On Tue, 2015-05-12 at 12:46 +0100, Stefano Stabellini wrote:
> > > > Would a separate clone of the same raisin version with some sort of
> > > > "dist" directory transported over be sufficient and supportable? Or are
> > > > raisin's outputs not in one place and easily transportable?
> > > >
> > > > i.e. today build-$ARCH-libvirt picks up the dist.tar.gz files from the
> > > > corresponding build-$ARCH, unpacks them and asks libvirt to build
> > > > against that tree.
> > > 
> > > Moving the dist directory over should work, although I have never tested
> > > this configuration.
> > 
> > Would you be willing to support this as a requirement going forward?
> 
> Yeah, I think it is OK
> 
> > I assume that it is not also necessary to reclone all the trees for the
> > preexisting components, just the new ones?
> 
> Only if the user asks for a components to be built, the corresponding
> tree is cloned.

OK, so the general pattern would be

ts-xen-build:

        Clones raisin
        
        Calls raisin with COMPONENTS="xen seabios qemu qemu-trad"
        # Essentially the current set from xen.git:Config.mk

        Builds xendist.tar and dist.tar from raisin's outputdir
        
ts-foo-build 

        Clones raisin

        Unpacks result of ts-xen-build into $WHERE (and any other
        required components, of which I expect there will be few)
        
        Calls raisin with COMPONENTS="foo"
        
        Builds dist.tar of that 
        
Where the obvious foo right now is libvirt, but eventually would include
grub2 etc. We might also eventually consider moving things out of
ts-xen-build.

I didn't say it, but in both cases there is an implicit "if
$r{use_raisin} else to the old thing fi" there.

The only problem I foresee is that if $WHERE above == raisin's outputdir
then foo's dist.tar would include all of the Xen stuff. How hard would
it be to have those split?

Ian.