From: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com,
dgilbert@redhat.com, vsementsov@parallels.com,
stefanha@redhat.com, den@openvz.org, amit.shah@redhat.com,
pbonzini@redhat.com, jsnow@redhat.com
Subject: [Qemu-devel] [PATCH 03/12] block: tiny refactoring: minimize hbitmap_(set/reset) usage
Date: Wed, 13 May 2015 18:29:58 +0300 [thread overview]
Message-ID: <1431531007-10269-4-git-send-email-vsementsov@parallels.com> (raw)
In-Reply-To: <1431531007-10269-1-git-send-email-vsementsov@parallels.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
---
block.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index fede5e2..8376e8d 100644
--- a/block.c
+++ b/block.c
@@ -3308,8 +3308,7 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap,
void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap)
{
- assert(bdrv_dirty_bitmap_enabled(bitmap));
- hbitmap_reset(bitmap->bitmap, 0, bitmap->size);
+ bdrv_reset_dirty_bitmap(bitmap, 0, bitmap->size);
}
const char *bdrv_dirty_bitmap_name(const BdrvDirtyBitmap *bitmap)
@@ -3356,7 +3355,7 @@ void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector,
if (!bdrv_dirty_bitmap_enabled(bitmap)) {
continue;
}
- hbitmap_set(bitmap->bitmap, cur_sector, nr_sectors);
+ bdrv_set_dirty_bitmap(bitmap, cur_sector, nr_sectors);
}
}
@@ -3368,7 +3367,7 @@ void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector,
if (!bdrv_dirty_bitmap_enabled(bitmap)) {
continue;
}
- hbitmap_reset(bitmap->bitmap, cur_sector, nr_sectors);
+ bdrv_reset_dirty_bitmap(bitmap, cur_sector, nr_sectors);
}
}
--
1.9.1
next prev parent reply other threads:[~2015-05-13 16:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 15:29 [Qemu-devel] [PATCH v5 00/12] Dirty bitmaps migration Vladimir Sementsov-Ogievskiy
2015-05-13 15:29 ` [Qemu-devel] [PATCH 01/12] hbitmap: serialization Vladimir Sementsov-Ogievskiy
2015-05-13 15:29 ` [Qemu-devel] [PATCH 02/12] block: BdrvDirtyBitmap serialization interface Vladimir Sementsov-Ogievskiy
2015-05-13 15:29 ` Vladimir Sementsov-Ogievskiy [this message]
2015-05-13 15:29 ` [Qemu-devel] [PATCH 04/12] block: add meta bitmaps Vladimir Sementsov-Ogievskiy
2015-05-28 22:13 ` John Snow
2015-05-13 15:30 ` [Qemu-devel] [PATCH 05/12] block: add bdrv_next_dirty_bitmap() Vladimir Sementsov-Ogievskiy
2015-05-13 15:30 ` [Qemu-devel] [PATCH 06/12] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2015-05-13 15:30 ` [Qemu-devel] [PATCH 07/12] migration: add migration/block-dirty-bitmap.c Vladimir Sementsov-Ogievskiy
2015-06-02 21:56 ` John Snow
2015-05-13 15:30 ` [Qemu-devel] [PATCH 08/12] iotests: maintain several vms in test Vladimir Sementsov-Ogievskiy
2015-05-13 15:30 ` [Qemu-devel] [PATCH 09/12] iotests: add add_incoming_migration to VM class Vladimir Sementsov-Ogievskiy
2015-05-13 15:30 ` [Qemu-devel] [PATCH 10/12] qapi: add md5 checksum of last dirty bitmap level to query-block Vladimir Sementsov-Ogievskiy
2015-05-13 15:30 ` [Qemu-devel] [PATCH 11/12] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2015-06-02 22:07 ` John Snow
2015-05-13 15:30 ` [Qemu-devel] [PATCH 12/12] migration/qemu-file: make functions qemu_(get/put)_string public Vladimir Sementsov-Ogievskiy
2015-05-21 13:51 ` [Qemu-devel] [PATCH v5 00/12] Dirty bitmaps migration Vladimir Sementsov-Ogievskiy
2015-05-21 13:57 ` Denis V. Lunev
2015-05-21 16:44 ` John Snow
2015-05-26 14:48 ` Denis V. Lunev
2015-05-26 14:51 ` Denis V. Lunev
2015-05-28 20:09 ` John Snow
2015-05-28 20:56 ` Denis V. Lunev
2015-06-02 22:17 ` John Snow
2015-06-05 10:51 ` Denis V. Lunev
2016-01-26 8:45 ` Vladimir Sementsov-Ogievskiy
2016-01-26 22:57 ` John Snow
2016-01-27 1:17 ` Fam Zheng
2015-06-02 22:12 ` John Snow
2015-06-03 9:10 ` Vladimir Sementsov-Ogievskiy
2015-06-12 22:16 ` John Snow
2015-06-19 16:57 ` Denis V. Lunev
2015-06-19 17:38 ` John Snow
-- strict thread matches above, loose matches on Subject: below --
2015-08-07 9:32 [Qemu-devel] [PATCH v6 " Vladimir Sementsov-Ogievskiy
2015-08-07 9:32 ` [Qemu-devel] [PATCH 03/12] block: tiny refactoring: minimize hbitmap_(set/reset) usage Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431531007-10269-4-git-send-email-vsementsov@parallels.com \
--to=vsementsov@parallels.com \
--cc=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.