From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v6 02/16] libxc/save: Adjust stream-position callbacks for checkpointed streams Date: Thu, 14 May 2015 12:19:44 +0100 Message-ID: <1431602384.13579.39.camel@citrix.com> References: <1431593718-4828-1-git-send-email-yanghy@cn.fujitsu.com> <1431593718-4828-3-git-send-email-yanghy@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1431593718-4828-3-git-send-email-yanghy@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-05-14 at 16:55 +0800, Yang Hongyang wrote: > From: Andrew Cooper > > There are some records which should only be sent once in the stream, and not > repeated for each checkpoint. {start,end}_of_stream() become per-checkpoint, > and a new start_of_stream() is introduced. > > There is no resulting change record order, but the X86_PV_INFO record is > identified as once per stream. Currently the X86_PV_P2M_FRAMES record is as > well, but this is because of an implementation bug and can move back to being > on an as-needed basis when fixed. > > In addition, a few minor adjustments of comments and layout. > > Signed-off-by: Andrew Cooper You pointed me to the docs in v5, so my previous Acked-by: Ian Campbell stands. (just replying here so I don't have to check two threads when I come to reply).