From: Ian Campbell <ian.campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: wei.liu2@citrix.com, xen-devel@lists.xensource.com,
ian.jackson@eu.citrix.com
Subject: Re: [PATCH] [RFC] run QEMU as non-root
Date: Fri, 15 May 2015 12:32:35 +0100 [thread overview]
Message-ID: <1431689555.8943.93.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1505151142080.20496@kaball.uk.xensource.com>
On Fri, 2015-05-15 at 11:46 +0100, Stefano Stabellini wrote:
> On Fri, 15 May 2015, Ian Campbell wrote:
> > On Thu, 2015-05-14 at 18:52 +0100, Stefano Stabellini wrote:
> > > Run QEMU as non-root. Starting from uid 6000, the chosen uid is
> > > base+domid. If the uid doesn't exist, try just 6000. This is less
> > > secure: ideally we don't want different domains having their QEMUs
> > > running with the same uid. Finally if uid 6000 doesn't exist either,
> > > fall back to running QEMU as root.
> >
> > We can't just pick a random number like that, especially not hardcoded.
> >
> > You should call getpwent_r.
>
> Are you suggesting to go over the full list of records in passwd? It
> doesn't sound like a good idea. Did you mean getpwnam_r?
yes, sorry.
prev parent reply other threads:[~2015-05-15 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 17:52 [PATCH] [RFC] run QEMU as non-root Stefano Stabellini
2015-05-15 9:25 ` Ian Campbell
2015-05-15 10:46 ` Stefano Stabellini
2015-05-15 11:32 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431689555.8943.93.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.