From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V3 2/6] libxl_read_file_contents: fix
	reading sysfs file
Date: Mon, 18 May 2015 15:28:21 +0100
Message-ID: <1431959301.4944.65.camel@citrix.com>
References: <1429415452-6161-1-git-send-email-cyliu@suse.com>
	<1429415452-6161-3-git-send-email-cyliu@suse.com>
	<21849.62954.924664.677204@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21849.62954.924664.677204@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: lars.kurth@citrix.com, wei.liu2@citrix.com, george.dunlap@eu.citrix.com, Chunyan Liu <cyliu@suse.com>, xen-devel@lists.xen.org, caobosimon@gmail.com
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-05-18 at 15:23 +0100, Ian Jackson wrote:
> Perhaps the bulk should be made into libxl__read_file_contents_core
> which takes a boolean instructing whether to tolerate magically
> shrinking files ?
> 
> Setting that boolean probably ought to arrange to insist that the
> function gets eof, in case the file is actually bigger rather than
> smaller than the size.
> 
> 
> Ian, Wei ?

Sounds ok to me.