Re: [PATCH v3] libibverbs init.c: conditionally emit warning if no userspace driver found

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 3367 bytes --]

On Tue, 2015-05-19 at 16:14 +0200, Yann Droneaud wrote:
> Hi Jeff,
> 
> Le mardi 19 mai 2015 à 14:11 +0000, Jeff Squyres (jsquyres) a écrit :
> > Doug --
> > 
> > The feedback on this patch seems to have converged.  What's the 
> > process for getting this accepted into libibverbs (and rolling a new 
> > libibverbs release)?
> > 
> > 
> 
> Is Doug the maintainer of the userspace library ?

Libibverbs and the kernel verbs interface are very closely tied, so I
did ask Roland if he was OK with me taking over that as well.  It would
make it easier to keep the two in sync.  Roland was fine with that.  If
anyone has any objections, please speak now.

> 
> > > On May 12, 2015, at 10:14 AM, Jeff Squyres (jsquyres) <
> > > jsquyres-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> wrote:
> > > 
> > > It's not a warning or an error if libibverbs cannot find a 
> > > userspace
> > > driver for kernel devices.  Indeed, returning a num_devices of is
> > > sufficient -- the middleware shouldn't be unconditionally printing 
> > > out
> > > stderr message; let the upper layer application do that (if it 
> > > wants
> > > to).
> > > 
> > > For debugging purposes, if the environment variable 
> > > IBV_SHOW_WARNINGS
> > > is set (to any value), warnings will be emitted to stderr if a
> > > corresponding userspace driver cannot be found for a kernel device.
> > > 
> > > Signed-off-by: Jeff Squyres <jsquyres-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
> > > ---
> > > man/ibv_get_device_list.3 | 6 ++++++
> > > src/init.c                | 2 +-
> > > 2 files changed, 7 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/man/ibv_get_device_list.3 b/man/ibv_get_device_list.3
> > > index 16cc1a0..96de554 100644
> > > --- a/man/ibv_get_device_list.3
> > > +++ b/man/ibv_get_device_list.3
> > > @@ -50,6 +50,12 @@ Client code should open all the devices it 
> > > intends to use with
> > > Once it frees the array with
> > > .B ibv_free_device_list()\fR,
> > > it will be able to use only the open devices; pointers to unopened 
> > > devices will no longer be valid.
> > > +.P
> > > +Setting the environment variable
> > > +.BR IBV_SHOW_WARNINGS
> > > +will cause warnings to be emitted to stderr if a kernel verbs 
> > > device
> > > +is discovered, but no corresponding userspace driver can be found 
> > > for
> > > +it.
> > > .SH "SEE ALSO"
> > > .BR ibv_fork_init (3),
> > > .BR ibv_get_device_name (3),
> > > diff --git a/src/init.c b/src/init.c
> > > index d0e4b1c..dbdd795 100644
> > > --- a/src/init.c
> > > +++ b/src/init.c
> > > @@ -561,7 +561,7 @@ out:
> > >                  next_dev = sysfs_dev ? sysfs_dev->next : 
> > > NULL;
> > >          sysfs_dev;
> > >          sysfs_dev = next_dev, next_dev = sysfs_dev ? 
> > > sysfs_dev->next : NULL) {
> > > -           if (!sysfs_dev->have_driver) {
> > > +           if (!sysfs_dev->have_driver && 
> > > getenv("IBV_SHOW_WARNINGS")) {
> > >                     fprintf(stderr, PFX "Warning: no userspace 
> > > device-specific "
> > >                             "driver found for %s\n", sysfs_dev
> > > ->sysfs_path);
> > >                     if (statically_linked)
> > > -- 
> > > 2.2.1
> > > 
> > 
> > 
> 


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]