From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
Paul Tan <pyokagan@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Stefan Beller <sbeller@google.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH v2] pull: handle --log=<n>
Date: Wed, 20 May 2015 10:11:46 +0200 [thread overview]
Message-ID: <1432109506.18433.0.camel@kaarsemaker.net> (raw)
In-Reply-To: <xmqqegmcour4.fsf@gitster.dls.corp.google.com>
On di, 2015-05-19 at 19:19 -0700, Junio C Hamano wrote:
> Hopefully now you have some idea how your approach is problematic.
Yes, thanks for the thorough explanation!
Two more bad sideeffects, so two more reasons not to take this approach:
- test_must_fail tests might now fail for the wrong reason, undetectedly
("ref does not exist" instead of "can't handle ref")
- same for TODO tests
--
Dennis Kaarsemaker
www.kaarsemaker.net
next prev parent reply other threads:[~2015-05-20 8:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 13:39 [PATCH v2] pull: handle --log=<n> Paul Tan
2015-05-18 14:53 ` Johannes Schindelin
2015-05-18 18:18 ` Junio C Hamano
2015-05-19 13:35 ` Johannes Schindelin
2015-05-19 13:57 ` Junio C Hamano
2015-05-19 21:24 ` Dennis Kaarsemaker
2015-05-19 21:33 ` Stefan Beller
2015-05-19 21:43 ` Dennis Kaarsemaker
2015-05-19 21:37 ` Junio C Hamano
2015-05-19 21:49 ` Dennis Kaarsemaker
2015-05-19 22:10 ` Junio C Hamano
2015-05-19 22:30 ` Dennis Kaarsemaker
2015-05-19 23:14 ` Junio C Hamano
2015-05-20 2:19 ` Junio C Hamano
2015-05-20 8:11 ` Dennis Kaarsemaker [this message]
2015-05-20 5:10 ` Junio C Hamano
2015-05-20 8:13 ` Dennis Kaarsemaker
2015-05-21 10:36 ` [PATCH v3] " Paul Tan
2015-05-21 21:24 ` Junio C Hamano
2015-05-22 13:29 ` Paul Tan
2015-05-18 15:15 ` [PATCH v2] " Paul Tan
2015-05-18 15:26 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432109506.18433.0.camel@kaarsemaker.net \
--to=dennis@kaarsemaker.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=pyokagan@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.