All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.
Date: Wed, 20 May 2015 15:41:39 +0200	[thread overview]
Message-ID: <1432129299.19214.16.camel@sipsolutions.net> (raw)
In-Reply-To: <CABPxzY+7KDGRs3fO1wsy3FPt__YPBnzr5CcZ_HTEh2ePsdtUdQ@mail.gmail.com> (sfid-20150519_102409_031094_7235378B)

On Tue, 2015-05-19 at 13:53 +0530, Krishna Chaitanya wrote:

> > I'm not sure I get it - we always transmit a frame after resume.
> Let me explain the sequence of events:
> 
> tx_frame:
>       dynamic_ps_disable_work.
>                  get the chip out of power save.
> suspend came:
>      dynamic ps timer is cancelled.
>     tx queues are flushed.
> chip stays out of power save unless there is one more
> tx frame which kicks the dynamic ps timer again.

So initially, for suspend, this shouldn't matter.

And after suspend we always transmit a frame. What gives?

johannes


  reply	other threads:[~2015-05-20 13:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1431602181-17700-1-git-send-email-chaitanya.mgit@gmail.com>
2015-05-19  7:31 ` [PATCH] mac80211: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet Johannes Berg
2015-05-19  8:23   ` Krishna Chaitanya
2015-05-20 13:41     ` Johannes Berg [this message]
2015-05-20 13:57       ` Krishna Chaitanya
2015-05-31 10:22 Chaitanya T K
2015-05-31 10:23 ` Krishna Chaitanya
2015-06-01 14:45 ` Johannes Berg
     [not found] <1431939609-7261-1-git-send-email-chaitanya.mgit@gmail.com>
2015-05-18  9:05 ` Johannes Berg
2015-05-18  9:19   ` Krishna Chaitanya
2015-05-18  9:24     ` Johannes Berg
2015-05-18  9:28       ` Krishna Chaitanya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432129299.19214.16.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=chaitanya.mgit@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.