From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Hu Subject: Re: [OSSTEST Nested PATCH v10 0/9] Introduction of netsted HVM test job Date: Thu, 21 May 2015 14:56:20 +0800 Message-ID: <1432191380.26800.4.camel@localhost> References: <1431488204-14510-1-git-send-email-longtaox.pang@intel.com> <1432136358.12989.286.camel@citrix.com> Reply-To: robert.hu@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1432136358.12989.286.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, "longtao.pang" , robert.hu@intel.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-05-20 at 16:39 +0100, Ian Campbell wrote: > On Wed, 2015-05-13 at 11:36 +0800, longtao.pang wrote: > > parsing grub which has 'submenu' primitive > > Changes to support '/boot' leading paths of kernel, xen, in grub > > Refactor installation of overlays for guest used > > Edit some APIs in TestSupport.pm for nested test > > Move the codes about memory size setting into prep() > > I've pushed the patches up to here into the osstest pretest branch from > where it will be tested before becoming the production version of > osstest. > > The next patch had a couple of comments which is why I stopped here. > Also it is useful to let refactoring type stuff go through in a flight > of its own. > > I made a couple of mods as I applied: > > In the first patch I adjusted an "if(stuff){" into "if (stuff) {" > > In the fourth patch I had to resolve a conflict with the newly added > ${viftype} code. Since I was there I also made ${vifmodel} a prefixing > thing like ${viftype} is for consistency. > > I also included my "grub: remove patch to disable submenu from > 20_linux_xen overlay" patch since it shouldn't be needed after your > first change. > > I've pushed the resulting branch to: > git://xenbits.xen.org/people/ianc/osstest.git > nestedhvm-v10-pretest > > since you can't see it otherwise. If the tests don't pass for some > reason we may need to rewind and try again, in which case you'll want to > start with those versions. Thanks Ian for your kindly review/modification and other helps. I've checked that branch and see those of our patches your pushed. So with regarding to our next(v11) patch: 1. shall we still include these patches you already pushed or not? 2. shall we based on this git://xenbits.xen.org/people/ianc/osstest.git nestedhvm-v10-pretest branch or git://xenbits.xen.org/osstest.git master branch? > > Test reports for osstest's own gate only go to Ian and myself, I'll copy > the list and you as necessary, otherwise keep an eye on > http://xenbits.xen.org/gitweb/?p=osstest.git;a=summary for your stuff > showing up in master in a day or two. > > Ian. >