Re: [OSSTEST Nested PATCH v10 0/9] Introduction of netsted HVM test job

[Ian Campbell <ian.campbell@citrix.com>]

On Thu, 2015-05-21 at 14:56 +0800, Robert Hu wrote:
> On Wed, 2015-05-20 at 16:39 +0100, Ian Campbell wrote:
> > On Wed, 2015-05-13 at 11:36 +0800, longtao.pang wrote:
> > >       parsing grub which has 'submenu' primitive
> > >       Changes to support '/boot' leading paths of kernel, xen, in grub
> > >       Refactor installation of overlays for guest used
> > >       Edit some APIs in TestSupport.pm for nested test
> > >       Move the codes about memory size setting into prep()
> > 
> > I've pushed the patches up to here into the osstest pretest branch from
> > where it will be tested before becoming the production version of
> > osstest.
> > 
> > The next patch had a couple of comments which is why I stopped here.
> > Also it is useful to let refactoring type stuff go through in a flight
> > of its own.
> > 
> > I made a couple of mods as I applied:
> > 
> > In the first patch I adjusted an "if(stuff){" into "if (stuff) {"
> > 
> > In the fourth patch I had to resolve a conflict with the newly added
> > ${viftype} code. Since I was there I also made ${vifmodel} a prefixing
> > thing like ${viftype} is for consistency.

I managed to introduce a typo here "vidmodel". I've fixed and repushed
both my xenbits branch and osstest's pretest.

(Ian: I didn't kill the inprogress flight since it is actually doing a
baseline test of the bisector stuff you pushed yesterday and not yet
testing the stuff in this batch).

> > I also included my "grub: remove patch to disable submenu from
> > 20_linux_xen overlay" patch since it shouldn't be needed after your
> > first change.
> > 
> > I've pushed the resulting branch to:
> >         git://xenbits.xen.org/people/ianc/osstest.git
> >         nestedhvm-v10-pretest
> > 
> > since you can't see it otherwise. If the tests don't pass for some
> > reason we may need to rewind and try again, in which case you'll want to
> > start with those versions.
> Thanks Ian for your kindly review/modification and other helps.
> I've checked that branch and see those of our patches your pushed.
> So with regarding to our next(v11) patch:
> 1. shall we still include these patches you already pushed or not?

It depends on whether they pass the push gate or not.

Until we have an actual result lets assume they will and therefore not
include these patches.

> 2. shall we based on this git://xenbits.xen.org/people/ianc/osstest.git
>         nestedhvm-v10-pretest branch 
> or 
> 	git://xenbits.xen.org/osstest.git master branch?

Since you are not including those patches you will want to use
nestedhvm-v10-pretest, remember to repull with the typo fixed though.