From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] xen/arm: gic-v3: Implement correctly the
 callback send_SGI
Date: Thu, 21 May 2015 15:50:24 +0100
Message-ID: <1432219824.10746.52.camel@citrix.com>
References: <1431104472-23616-1-git-send-email-julien.grall@citrix.com>
	<20150509131328.GA12647@cbz-thinkpad>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YvSIB-0008E5-QX
	for xen-devel@lists.xenproject.org; Thu, 21 May 2015 15:21:51 +0000
In-Reply-To: <20150509131328.GA12647@cbz-thinkpad>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Chen Baozi <baozich@gmail.com>
Cc: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Sat, 2015-05-09 at 21:13 +0800, Chen Baozi wrote:
> On Fri, May 08, 2015 at 06:01:12PM +0100, Julien Grall wrote:
> > Currently, the GICv3 driver is only able to send an SGI when the cpumask
> > is provided. Although with the modes SGI_TARGET_OTHERS and SGI_TARGET_SELF,
> > no cpumask is provided. Any usage of those modes will crash the hypersivor.
> > 
> > Rename gicv3_send_sgi to gicv3_send_sgi_list and implement the
> > different modes:
> >     - SGI_TARGET_OTHERS: Set the Interrupt Routing Mode (bit 40) to 1
> >     (see Table 4 on Section 4.2.6 PRD03-GENC-010745 24.0)
> >     - SGI_TARGET_SELF: Unlike GICv2, the GICv3 SGI registers don't
> >     provide a specific field. So use gicv3_send_sgi_list and pass
> >     the cpumask of the current CPU
> >     - SGI_TARGET_LIST: Directly call gicv3_send_sgi_list with the given
> >     cpumask
> > 
> > Also, use WRITE_SYSREG64 to write into ICC_SGI1R_EL1 the access is
> > 64-bit on all the architectures.
> > 
> > Reported-by: Chen Baozi <baozich@gmail.com>
> > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> Tested-by: Chen Baozi <baozich@gmail.com>

Acked + applied, thanks.