From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] tools: add configure --with-dumpdir=DIR option Date: Thu, 21 May 2015 16:23:28 +0100 Message-ID: <1432221808.10746.84.camel@citrix.com> References: <1431358431-6345-1-git-send-email-olaf@aepfle.de> <1432217349.10746.33.camel@citrix.com> <20150521142755.GA32716@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150521142755.GA32716@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Wei Liu , xen-devel@lists.xen.org, Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thu, 2015-05-21 at 16:27 +0200, Olaf Hering wrote: > On Thu, May 21, Ian Campbell wrote: > > > On Mon, 2015-05-11 at 15:33 +0000, Olaf Hering wrote: > > [...] > > > +AC_ARG_WITH([xen-dumpdir], > > > + AS_HELP_STRING([--with-xen-dumpdir=DIR], > > > + [Path to directory for domU crash dumps. [/var/lib/xen/dump]]), > > > > Should this say $localstatedir/lib/xen/dump as below? > > This is the help output, the line below is a variable assignment. > I think its ok as it is. Perhaps /var can be replaced with LOCALSTATEDIR > to make it clearer. Based on the other things in configure --help I think that's right. Ive applied making that change, thanks. > configure --help suggests that --localestatedir is PREFIX/var, but we > force it to be /var. Too bad that can not be changed because it comes > from generic code, I think. I vaguely recall coming to the same conclusion when I looked at this :-(