All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: David Cohen <david.a.cohen@linux.intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	qiuxu.zhuo@intel.com, Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall
Date: Fri, 22 May 2015 10:07:05 +0800	[thread overview]
Message-ID: <1432260425-2350-1-git-send-email-baolu.lu@linux.intel.com> (raw)

Many drivers and modules depend on ULPI bus registeration to
register ULPI interfaces and drivers. It's more appropriate
to register ULPI bus in subsys_initcall instead of module_init.

Kernel panic has been reported with some kind of kernel config.

[0.746856] kernel BUG at drivers/base/driver.c:153!
[0.752418] invalid opcode: 0000 [#1] PREEMPT SMP
[0.757804] Modules linked in:
[0.893985] Call Trace:
[0.896729]  [<ffffffff81870cb1>] ? ulpi_register_driver+0x21/0x30
[0.903654]  [<ffffffff823d5cac>] tusb1210_driver_init+0x10/0x12
[0.910386]  [<ffffffff81000318>] do_one_initcall+0xd8/0x200
[0.916729]  [<ffffffff8239b094>] kernel_init_freeable+0x196/0x21e
[0.923655]  [<ffffffff81affed0>] ? rest_init+0x90/0x90
[0.929509]  [<ffffffff81affede>] kernel_init+0xe/0xf0
[0.935266]  [<ffffffff81b0f442>] ret_from_fork+0x42/0x70
[0.941315]  [<ffffffff81affed0>] ? rest_init+0x90/0x90

This patch fixes this kind of kernel panic by putting ulpi_init in
subsys_initcall().

Reported-by: Zhuo Qiuxu <qiuxu.zhuo@intel.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/usb/common/ulpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
index 0e6f968..01c0c04 100644
--- a/drivers/usb/common/ulpi.c
+++ b/drivers/usb/common/ulpi.c
@@ -242,7 +242,7 @@ static int __init ulpi_init(void)
 {
 	return bus_register(&ulpi_bus);
 }
-module_init(ulpi_init);
+subsys_initcall(ulpi_init);
 
 static void __exit ulpi_exit(void)
 {
-- 
2.1.4


             reply	other threads:[~2015-05-22  2:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22  2:07 Lu Baolu [this message]
2015-05-22  3:09 ` [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall David Cohen
2015-05-22  3:11   ` David Cohen
2015-05-22  6:46     ` Lu, Baolu
2015-05-22  7:50       ` Lu, Baolu
2015-05-22 16:12         ` David Cohen
2015-05-22 10:07       ` Heikki Krogerus
2015-05-24 16:25     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432260425-2350-1-git-send-email-baolu.lu@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=david.a.cohen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=qiuxu.zhuo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.