From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay0200.hostedemail.com ([216.40.44.200]:57316 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750970AbbEVEnA (ORCPT ); Fri, 22 May 2015 00:43:00 -0400 Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave04.hostedemail.com (Postfix) with ESMTP id 81251B1968 for ; Fri, 22 May 2015 04:37:04 +0000 (UTC) Message-ID: <1432269418.29657.5.camel@perches.com> Subject: Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. From: Joe Perches To: Kevin Tsai Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Andrew Morton , Greg KH , "David S. Miller" , Mauro Carvalho Chehab , Arnd Bergmann , Jingoo Han , Daniel Baluta , Roberta Dobrescu , Kuppuswamy Sathyanarayanan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Date: Thu, 21 May 2015 21:36:58 -0700 In-Reply-To: <1432268380-7302-1-git-send-email-ktsai@capellamicro.com> References: <1432268380-7302-1-git-send-email-ktsai@capellamicro.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Thu, 2015-05-21 at 21:19 -0700, Kevin Tsai wrote: > - Renamed company name. > - Removed cm32181_reg. > - Removed white space. > - Removed unused include files. > - Updated macro definitions. > - Renamed cm32181_chip pointer to chip. Hi Kevin, Please don't use the same title for multiple patches. It'd be better if these 6 patches were titled something like 1/6 cm32181: Neatening 2/6 cm32181: Add cm32181_als_info 3/6: cm32181: Add power management support 4/6: cm32181: Add and use cm32181_als_it_scale 5/6: cm32181: Add device tree support 6/6: cm32181: Add interrupt suppor It's