From: Johannes Berg <johannes@sipsolutions.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Marcel Holtmann <marcel@holtmann.org>,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH 7/7] mac80211: Switch to new AEAD interface
Date: Fri, 22 May 2015 09:32:28 +0200 [thread overview]
Message-ID: <1432279948.3493.2.camel@sipsolutions.net> (raw)
In-Reply-To: <E1YvNxS-00063i-AZ@gondolin.me.apana.org.au>
On Thu, 2015-05-21 at 18:44 +0800, Herbert Xu wrote:
> This patch makes use of the new AEAD interface which uses a single
> SG list instead of separate lists for the AD and plain text.
The CCM and GCM part seems to work, but GMAC causes a kernel crash:
[ 26.143579] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 26.144406] IP: [<ffffffff811d9e7d>] scatterwalk_map_and_copy+0x3d/0xd0
[ 26.145071] PGD da3a067 PUD d9ee067 PMD 0
[ 26.145514] Oops: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
[ 26.146146] CPU: 1 PID: 661 Comm: hostapd Not tainted 4.0.0+ #860
[ 26.146746] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014
[ 26.148333] task: ffff88000d9a4a20 ti: ffff880000070000 task.ti: ffff880000070000
[ 26.149625] RIP: 0010:[<ffffffff811d9e7d>] [<ffffffff811d9e7d>] scatterwalk_map_and_copy+0x3d/0xd0
[ 26.151223] RSP: 0018:ffff8800000733b8 EFLAGS: 00010246
[ 26.152156] RAX: 0000000000000000 RBX: 0000000000000010 RCX: 000077ff80000000
[ 26.153396] RDX: 0000000080000000 RSI: 0000000000000000 RDI: ffff8800000733c8
[ 26.153481] RBP: ffff880000073428 R08: 0000000000000001 R09: 0000000000000010
[ 26.153481] R10: 0000000000000010 R11: 0000000000000012 R12: 0000000000000001
[ 26.153481] R13: ffff8800000735f8 R14: 0000000000000000 R15: 0000000000000030
[ 26.153481] FS: 00007f20eee60700(0000) GS:ffff88000f600000(0000) knlGS:0000000000000000
[ 26.153481] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 26.153481] CR2: 0000000000000000 CR3: 000000000da2a000 CR4: 00000000000007a0
[ 26.153481] Stack:
[ 26.153481] 0000000000000000 0000000000000030 ffff8800000733d8 ffffffff811e05c6
[ 26.153481] ffff8800000733f8 ffffffff811df815 ffff8800000735f8 ffff880000073598
[ 26.153481] ffff880000073408 ffffffff811dfc86 ffff880000073438 ffff8800000735f8
[ 26.153481] Call Trace:
[ 26.153481] [<ffffffff811e05c6>] ? shash_async_final+0x16/0x20
[ 26.153481] [<ffffffff811df815>] ? crypto_ahash_op+0x25/0x60
[ 26.153481] [<ffffffff811dfc86>] ? crypto_ahash_final+0x16/0x20
[ 26.153481] [<ffffffff811e3608>] gcm_enc_copy_hash+0x28/0x30
[ 26.153481] [<ffffffff811e36fc>] crypto_gcm_encrypt+0xec/0x100
[ 26.153481] [<ffffffff811e3610>] ? gcm_enc_copy_hash+0x30/0x30
[ 26.153481] [<ffffffff811da875>] old_crypt+0xc5/0xe0
[ 26.153481] [<ffffffff811da8cd>] old_encrypt+0x1d/0x20
[ 26.153481] [<ffffffff814b688b>] ieee80211_aes_gmac+0x21b/0x230
[ 26.153481] [<ffffffff811e3710>] ? crypto_gcm_encrypt+0x100/0x100
[ 26.153481] [<ffffffff811e2f10>] ? __gcm_hash_final_done+0x60/0x60
[ 26.153481] [<ffffffff814b66a4>] ? ieee80211_aes_gmac+0x34/0x230
[ 26.153481] [<ffffffff81498621>] ieee80211_crypto_aes_gmac_encrypt+0x191/0x1a0
[ 26.153481] [<ffffffff8153b794>] ieee80211_tx_h_encrypt+0x67/0x77
[ 26.153481] [<ffffffff814cd496>] invoke_tx_handlers+0xe6/0x1b0
johannes
next prev parent reply other threads:[~2015-05-22 7:32 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 10:39 [PATCH 0/7] crypto: Convert all AEAD users to new interface Herbert Xu
2015-05-21 10:43 ` [PATCH 1/7] crypto: testmgr - Switch to new AEAD interface Herbert Xu
2015-05-21 10:43 ` [PATCH 2/7] xfrm: Add IV generator information to xfrm_algo_desc Herbert Xu
2015-05-21 10:43 ` [PATCH 3/7] ipsec: Add IV generator information to xfrm_state Herbert Xu
2015-05-21 10:43 ` [PATCH 4/7] esp4: Switch to new AEAD interface Herbert Xu
2015-05-21 10:44 ` [PATCH 5/7] esp6: " Herbert Xu
2015-05-22 6:40 ` Stephan Mueller
2015-05-22 6:45 ` Herbert Xu
2015-05-22 7:16 ` Stephan Mueller
2015-05-22 7:19 ` Herbert Xu
2015-05-26 6:39 ` Stephan Mueller
2015-05-26 7:02 ` Stephan Mueller
2015-05-26 7:21 ` Herbert Xu
2015-05-26 7:37 ` Stephan Mueller
2015-05-26 7:38 ` Herbert Xu
2015-05-26 7:40 ` Herbert Xu
2015-05-26 7:56 ` Stephan Mueller
2015-05-26 7:57 ` Herbert Xu
2015-05-26 8:15 ` Stephan Mueller
2015-05-26 8:18 ` Herbert Xu
2015-05-26 8:27 ` Stephan Mueller
2015-05-21 10:44 ` [PATCH 6/7] mac802154: " Herbert Xu
2015-05-21 10:44 ` [PATCH 7/7] mac80211: " Herbert Xu
2015-05-21 11:20 ` Johannes Berg
2015-05-21 11:50 ` Herbert Xu
2015-05-21 12:17 ` Johannes Berg
2015-05-22 4:11 ` Herbert Xu
2015-06-01 13:21 ` Stephan Mueller
2015-06-01 13:42 ` Johannes Berg
2015-06-01 13:49 ` Stephan Mueller
2015-06-01 14:05 ` Johannes Berg
2015-06-01 14:35 ` Johannes Berg
[not found] ` <1433169326.3505.12.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2015-06-01 15:36 ` Stephan Mueller
2015-06-01 15:36 ` Stephan Mueller
2015-06-02 9:15 ` Jouni Malinen
2015-06-02 9:15 ` Jouni Malinen
2015-05-22 7:32 ` Johannes Berg [this message]
2015-05-22 7:41 ` Herbert Xu
2015-05-22 7:43 ` Johannes Berg
2015-05-22 8:05 ` Herbert Xu
2015-05-22 8:18 ` Johannes Berg
2015-05-22 8:19 ` Herbert Xu
2015-05-21 12:29 ` [PATCH 0/7] crypto: Convert all AEAD users to new interface Stephan Mueller
2015-05-22 0:18 ` Herbert Xu
2015-05-21 16:03 ` David Miller
2015-05-22 0:21 ` Herbert Xu
2015-05-22 8:27 ` [v2 PATCH 0/13] " Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 1/13] crypto: aead - Add crypto_aead_alg_ivsize/maxauthsize Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 2/13] crypto: seqiv - Use aead_register_instance Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 3/13] crypto: echainiv " Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 4/13] crypto: aead - Do not set cra_type for new style instances Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 5/13] crypto: testmgr - Switch to new AEAD interface Herbert Xu
2015-06-04 22:15 ` Tadeusz Struk
2015-06-05 3:57 ` Herbert Xu
2015-06-05 22:10 ` Tadeusz Struk
2015-06-07 7:06 ` Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 6/13] xfrm: Add IV generator information to xfrm_algo_desc Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 7/13] ipsec: Add IV generator information to xfrm_state Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 8/13] esp4: Switch to new AEAD interface Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 9/13] esp6: " Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 10/13] mac802154: " Herbert Xu
2015-05-22 8:31 ` [v2 PATCH 11/13] mac80211: " Herbert Xu
2015-05-22 8:31 ` [v2 PATCH 12/13] crypto: tcrypt - " Herbert Xu
2015-05-22 8:31 ` [v2 PATCH 13/13] crypto: algif_aead " Herbert Xu
2015-05-22 20:59 ` Stephan Mueller
2015-05-22 21:04 ` Stephan Mueller
2015-05-22 21:54 ` [PATCH 0/2] crypto: Use tmpl->create when registering geniv Herbert Xu
2015-05-22 21:58 ` [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface Herbert Xu
2015-05-23 18:04 ` Stephan Mueller
2015-05-23 18:04 ` Stephan Mueller
2015-05-24 3:34 ` Herbert Xu
2015-05-24 10:52 ` Stephan Mueller
2015-05-25 10:20 ` Herbert Xu
2015-05-25 11:50 ` Stephan Mueller
2015-05-25 11:53 ` Herbert Xu
2015-05-26 6:24 ` Herbert Xu
2015-05-26 6:44 ` Stephan Mueller
2015-05-26 7:36 ` Herbert Xu
2015-05-26 7:57 ` Stephan Mueller
2015-05-26 7:58 ` Herbert Xu
2015-05-27 8:01 ` [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 1/8] crypto: testmgr - Switch to new AEAD interface Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 2/8] xfrm: Add IV generator information to xfrm_algo_desc Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 3/8] ipsec: Add IV generator information to xfrm_state Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 4/8] esp4: Switch to new AEAD interface Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 5/8] esp6: " Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 6/8] mac802154: " Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 7/8] mac80211: " Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 8/8] crypto: tcrypt - " Herbert Xu
2015-05-27 8:15 ` [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface Johannes Berg
2015-05-27 8:39 ` Herbert Xu
2015-05-27 9:00 ` Johannes Berg
2015-05-27 9:07 ` Herbert Xu
2015-05-27 9:18 ` Johannes Berg
2015-05-27 9:25 ` Steffen Klassert
2015-05-27 9:29 ` Herbert Xu
2015-05-27 9:32 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432279948.3493.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.