All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH V5 01/16] perf tools: Disallow PMU events intel_pt and intel_bts until there is support
Date: Fri, 22 May 2015 14:53:58 +0300	[thread overview]
Message-ID: <1432295653-13989-2-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1432295653-13989-1-git-send-email-adrian.hunter@intel.com>

Disallow PMU events intel_pt and intel_bts until the tools
support them. By default any PMU is selectable as an event
but until the tools have intel_pt and intel_bts support
using them would result in no data being recorded without
any indication as to why.

Before the change:

    $ perf record -e intel_bts// sleep 1
    [ perf record: Woken up 1 times to write data ]
    [ perf record: Captured and wrote 0.008 MB perf.data ]
    $ perf report --stdio
    Error:
    The perf.data file has no samples!

After the change:

    $ perf record -e intel_bts// sleep 1
    invalid or unsupported event: 'intel_bts//'
    Run 'perf list' for a list of valid events

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 tools/perf/util/pmu.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 244c66f..5d3ab7c 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -442,6 +442,10 @@ static struct perf_pmu *pmu_lookup(const char *name)
 	LIST_HEAD(aliases);
 	__u32 type;
 
+	/* No support for intel_bts or intel_pt so disallow them */
+	if (!strcmp(name, "intel_bts") || !strcmp(name, "intel_pt"))
+		return NULL;
+
 	/*
 	 * The pmu data we store & need consists of the pmu
 	 * type value and format definitions. Load both right
-- 
1.9.1


  reply	other threads:[~2015-05-22 12:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 11:53 [PATCH V5 00/16] perf tools: Introduce an abstraction for AUX Area and Instruction Tracing Adrian Hunter
2015-05-22 11:53 ` Adrian Hunter [this message]
2015-05-27 16:52   ` [tip:perf/core] perf tools: Disallow PMU events intel_pt and intel_bts until there is support tip-bot for Adrian Hunter
2015-05-22 11:53 ` [PATCH V5 02/16] perf auxtrace: Add Intel PT as an AUX area tracing type Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 03/16] perf tools: Add Intel PT packet decoder Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 04/16] perf tools: Add Intel PT instruction decoder Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 05/16] perf tools: Add Intel PT log Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 06/16] perf tools: Add Intel PT decoder Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 07/16] perf tools: Add Intel PT support Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 08/16] perf tools: Take Intel PT into use Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 09/16] perf tools: Allow auxtrace data alignment Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 10/16] perf tools: Add Intel BTS support Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 11/16] perf tools: Output sample flags and insn_len from intel_pt Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 12/16] perf tools: Output sample flags and insn_len from intel_bts Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 13/16] perf tools: Intel PT to always update thread stack trace number Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 14/16] perf tools: Intel BTS " Adrian Hunter
2015-05-22 11:54 ` [PATCH V5 15/16] perf tools: Add example call-graph script Adrian Hunter
2015-05-26 15:43   ` Arnaldo Carvalho de Melo
2015-05-22 11:54 ` [PATCH V5 16/16] perf tools: Put itrace options into an asciidoc include Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432295653-13989-2-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.