All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jemma Denson <jdenson@gmail.com>
To: linux-media@vger.kernel.org
Cc: mchehab@osg.samsung.com, patrick.boettcher@posteo.de,
	Jemma Denson <jdenson@gmail.com>
Subject: [PATCH 4/4] b2c2: Always turn off receive stream
Date: Fri, 22 May 2015 21:28:28 +0100	[thread overview]
Message-ID: <1432326508-6825-5-git-send-email-jdenson@gmail.com> (raw)
In-Reply-To: <1432326508-6825-1-git-send-email-jdenson@gmail.com>

When letting an external device control the receive stream, it won't
know when there's demand for any feeds, so won't be turning off our
receive stream. This patch bring back control of turning it off in
this sitation.

The demod can still delay turning it on until it has data to send,
and still turn it off temporarily whilst it knows there's no
stream, such as whilst tuning.

Signed-off-by: Jemma Denson <jdenson@gmail.com>
---
 drivers/media/common/b2c2/flexcop-hw-filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/common/b2c2/flexcop-hw-filter.c b/drivers/media/common/b2c2/flexcop-hw-filter.c
index eceb9c5..8926c82 100644
--- a/drivers/media/common/b2c2/flexcop-hw-filter.c
+++ b/drivers/media/common/b2c2/flexcop-hw-filter.c
@@ -206,7 +206,7 @@ int flexcop_pid_feed_control(struct flexcop_device *fc,
 
 	/* if it was the first or last feed request change the stream-status */
 	if (fc->feedcount == onoff) {
-		if (!fc->external_stream_control)
+		if (!fc->external_stream_control || onoff == 0)
 			flexcop_rcv_data_ctrl(fc, onoff);
 
 		if (fc->stream_control) /* device specific stream control */
-- 
2.1.0


  parent reply	other threads:[~2015-05-22 20:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 20:28 [PATCH 0/4] SkystarS2 pid filtering fix and stream control Jemma Denson
2015-05-22 20:28 ` [PATCH 1/4] b2c2: Add option to skip the first 6 pid filters Jemma Denson
2015-05-22 20:28 ` [PATCH 2/4] b2c2: Allow external stream control Jemma Denson
2015-05-22 20:28 ` [PATCH 3/4] cx24120: Take control of b2c2 receive stream Jemma Denson
2015-05-26  9:05   ` Patrick Boettcher
2015-05-26  9:21     ` Jemma Denson
2015-06-09 23:56       ` Mauro Carvalho Chehab
2015-06-10  7:32         ` Jemma Denson
2015-05-22 20:28 ` Jemma Denson [this message]
2015-05-24 12:35   ` [PATCH 4/4] b2c2: Always turn off " Jemma Denson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432326508-6825-5-git-send-email-jdenson@gmail.com \
    --to=jdenson@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=patrick.boettcher@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.