From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Hu Subject: Re: [osstest test] 56922: regressions - FAIL Date: Sat, 23 May 2015 15:52:48 +0800 Message-ID: <1432367568.12629.1.camel@localhost> References: <1432288654.10746.161.camel@citrix.com> <1432294374.14664.12.camel@citrix.com> <1432297842.14664.32.camel@citrix.com> <1432298867.26800.5.camel@localhost> <1432299517.14664.37.camel@citrix.com> <1432302144.14664.43.camel@citrix.com> <1432304517.14664.48.camel@citrix.com> <1432352104.8273.3.camel@localhost> <1432363573.12038.5.camel@localhost> <1432364320.5748.146.camel@citrix.com> Reply-To: robert.hu@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1432364320.5748.146.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: robert.hu@intel.com, "Pang, LongtaoX" , ian.jackson@eu.citrix.com, xen-devel List-Id: xen-devel@lists.xenproject.org On Sat, 2015-05-23 at 07:58 +0100, Ian Campbell wrote: > On Sat, 2015-05-23 at 14:46 +0800, Robert Hu wrote: > > On Sat, 2015-05-23 at 11:35 +0800, Robert Hu wrote: > > > On Fri, 2015-05-22 at 15:21 +0100, Ian Campbell wrote: > > > > On Fri, 2015-05-22 at 14:42 +0100, Ian Campbell wrote: > > > > > From my particular grub.cfg. For real usage setupboot_grub2 will > > > > > obviously need to become cleverer to count things correctly. > > > > > > > > I've not tested extensively but the following incremental patch seems to > > > > do the right thing, at least by inspection of the resulting grub.cfg. > > > > > > > > Needs more testing (e.g. I haven't tried non-XSM yet) and review from > > > > Ian I think, since there may be a more idiomatically Perl way to > > > > manipulate the @offsets array (in particular shrinking it). > > > Thanks Ian. You are so quick. I wrote that piece of code almost a year > > > ago; was just about to warm up. > > > We're to test your fix in our environment as well on non-XSM. > > > > Just furbished up that piece of code. Now I recall the memory. This > > piece of code was developed before 'XSM' things introduced; though now > > after XSM things merged. May I know what is 'xsm' stuff? > > XSM is Xen Security Modules (sort of selinux for Xen). It involves some > special additional entries in grub to provide the policy. > > > Can you send me the 'grub.cfg' of those 'xsm' cases? so that I can take > > a look. > > All of the logs for the flight can be found at: > > http://logs.test-lab.xenproject.org/osstest/logs/56922/ > > Clicking the heading of one of the failing tests would take you to e.g.: > > http://logs.test-lab.xenproject.org/osstest/logs/56922/test-amd64-amd64-xl-xsm/info.html >>From the log I see 'boot check: grub2, found Debian GNU/Linux, with Xen 4.6-unstable (XSM enabled) and Linux 3.14.43+' Seems it finds what ought to be. > > and in there is: > > http://logs.test-lab.xenproject.org/osstest/logs/56922/test-amd64-amd64-xl-xsm/italia1--grub.cfg.1 > > Ian. >