From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Ywaj5-0004xQ-GQ for mharc-grub-devel@gnu.org; Sun, 24 May 2015 14:34:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ywaj2-0004x9-FZ for grub-devel@gnu.org; Sun, 24 May 2015 14:34:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ywaix-00027q-Fk for grub-devel@gnu.org; Sun, 24 May 2015 14:34:16 -0400 Received: from mail.gw90.de ([2a01:4f8:100:7463::3]:44471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ywaix-00027k-9X for grub-devel@gnu.org; Sun, 24 May 2015 14:34:11 -0400 Received: from p5de4181c.dip0.t-ipconnect.de ([93.228.24.28] helo=mattotaupa) by mail.gw90.de with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Ywaix-000413-Ki for grub-devel@gnu.org; Sun, 24 May 2015 18:34:11 +0000 Message-ID: <1432492437.3663.2.camel@users.sourceforge.net> Subject: Re: disk/ahci: Unaligned pointer with old commit as coreboot payload From: Paul Menzel To: grub-devel@gnu.org Date: Sun, 24 May 2015 20:33:57 +0200 In-Reply-To: <20150524212339.6bb1cac0@opensuse.site> References: <1432451020.3711.13.camel@users.sourceforge.net> <20150524131559.5cd2fe94@opensuse.site> <1432470628.2492.1.camel@users.sourceforge.net> <20150524212339.6bb1cac0@opensuse.site> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-B+mU4pi3bPgUpieD7BVl" X-Mailer: Evolution 3.12.12-1 Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:100:7463::3 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2015 18:34:17 -0000 --=-B+mU4pi3bPgUpieD7BVl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Andrei, Am Sonntag, den 24.05.2015, 21:23 +0300 schrieb Andrei Borzenkov: > =D0=92 Sun, 24 May 2015 14:30:28 +0200 Paul Menzel =D0=BF=D0=B8=D1=88=D0= =B5=D1=82: > > Am Sonntag, den 24.05.2015, 13:15 +0300 schrieb Andrei Borzenkov: > > > =D0=92 Sun, 24 May 2015 09:03:40 +0200 Paul Menzel =D0=BF=D0=B8=D1=88= =D0=B5=D1=82: > > > > > > > further trying to bisect the AHCI regression on, that the GRUB payl= oad > > > > does not detect the AHCI drive [1], I tried to build GRUB from comm= its > > > > changing `grub-core/disk/ahci.c`, I built commit dc2a6c8b (Improve = AHCI > > > > detection and command issuing.), but it it fails to boot with > > > >=20 > > > > Unaligned pointer =E2=80=A6 > > > > Aborted. > > > >=20 > > > > The same happens, when I just checkout that revision for `ahci.c` a= nd > > > > leave the rest as is. > > > >=20 > > > > $ git checkout dc2a6c8b0e3dfe3bce78dbe0febcd9d4d9038411 -- = grub-core/disk/ahci.c > > > > $ ./autogen.sh > > > > $ ./configure --with-plattform=3Dcoreboot > > > > $ make -j > > > > $ make default_payload.elf > > > >=20 > > > > I=E2=80=99ll attach that version of `ahci.c` to this message. Do yo= u see what > > > > could be causing that unaligned pointer? > > > >=20 > > >=20 > > > It is not clear - do you mean that this specific revision has this > > > problem and others not? Or that this problem happens since this > > > revision? > >=20 > > It=E2=80=99s happening whenever `ahci.c` from commit dc2a6c8b is used (= with > > commit dc2a6c8b and master). >=20 > It does not really answer my question - do you get this unaligned access > with current master? Sorry for the misunderstand. I do *not* get this unaligned access with current master. `ahci.c` was rewritten after commit dc2a6c8b. Thanks, Paul --=-B+mU4pi3bPgUpieD7BVl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlViGaAACgkQPX1aK2wOHVgu8wCePPwQghgb9vBfRqR96wsam8/D r6MAn3SZYCSKH9uRS8L4LAUM31PZSNdd =kCxr -----END PGP SIGNATURE----- --=-B+mU4pi3bPgUpieD7BVl--