From: Johannes Berg <johannes@sipsolutions.net>
To: "Jakub Kiciński" <moorray3@wp.pl>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Felix Fietkau <nbd@openwrt.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Jakub Kicinski <kubakici@wp.pl>
Subject: Re: [PATCHv2 0/2] add mt7601u driver
Date: Tue, 26 May 2015 09:16:33 +0200 [thread overview]
Message-ID: <1432624593.2141.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20150525113527.5b8b31c0@north>
On Mon, 2015-05-25 at 11:35 +0200, Jakub Kiciński wrote:
> I just dropped the line configuring HW promisc for now like Johannes
> did in his removal patch. However, the right fix is to configure it
> based on IEEE80211_CONF_MONITOR, correct?
The two aren't equivalent, so no.
FIF_PROMISC_IN_BSS was meant to receive frames promiscuously *within*
the BSS, i.e. everything with the right BSSID. This functionality
clearly cannot work with encryption etc. nor with a lot of HW etc. so I
decided to remove it. It seems unlikely that anyone could have used it
successfully.
Monitor mode, on the other hand, supposedly receives *everything* that
decodes correctly on the receiver.
johannes
next prev parent reply other threads:[~2015-05-26 7:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 13:01 [PATCH 0/2] add mt7601u driver moorray3
2015-05-02 13:01 ` [PATCH 1/2] " moorray3
2015-05-04 9:37 ` Johannes Berg
2015-05-04 10:04 ` Jakub Kiciński
2015-05-04 10:15 ` Johannes Berg
2015-05-05 0:49 ` Jakub Kiciński
2015-05-05 6:45 ` Johannes Berg
2015-05-05 10:44 ` Jakub Kiciński
2015-05-02 13:01 ` [PATCH 2/2] add mt7601u build infrastructure and co moorray3
2015-05-05 20:22 ` [PATCHv2 0/2] add mt7601u driver Jakub Kicinski
2015-05-05 20:22 ` [PATCHv2 1/2] " Jakub Kicinski
2015-05-05 20:22 ` [PATCHv2 2/2] add mt7601u kbuild and others Jakub Kicinski
2015-05-25 8:13 ` [PATCHv2 0/2] add mt7601u driver Kalle Valo
2015-05-25 9:35 ` Jakub Kiciński
2015-05-26 7:16 ` Johannes Berg [this message]
2015-05-25 9:34 ` [PATCHv3 " Jakub Kicinski
2015-05-25 9:34 ` [PATCHv3 1/2] " Jakub Kicinski
2015-05-25 9:34 ` [PATCHv3 2/2] add mt7601u kbuild and others Jakub Kicinski
2015-05-26 10:26 ` [PATCHv3 0/2] add mt7601u driver Kalle Valo
2015-05-26 9:16 ` [PATCHv4] " Jakub Kicinski
2015-05-28 8:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432624593.2141.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kubakici@wp.pl \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=moorray3@wp.pl \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.