From: Ian Campbell <ian.campbell@citrix.com>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com
Subject: Re: [PATCH 2/3] xen/flask: change bool_maxstr to PAGE_SIZE
Date: Wed, 27 May 2015 09:13:51 +0100 [thread overview]
Message-ID: <1432714431.14664.154.camel@citrix.com> (raw)
In-Reply-To: <1432664009-10532-2-git-send-email-dgdegra@tycho.nsa.gov>
On Tue, 2015-05-26 at 14:13 -0400, Daniel De Graaf wrote:
> When FLASK_{GET,SET}BOOL is called with a named boolean, the call to
> flask_security_resolve_bool is made prior to bool_maxstr being populated
> by flask_security_make_bools. This results in the maximum string length
> being specified as zero, which is not useful. While it would be
> possible to initialize bool_maxstr correctly prior to its use, it is
> simpler to use a fixed maximum of PAGE_SIZE as is done for the other
> calls to safe_copy_string_from_guest.
>
> Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-05-27 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 18:13 [PATCH 1/3] flask/policy: updates from osstest runs Daniel De Graaf
2015-05-26 18:13 ` [PATCH 2/3] xen/flask: change bool_maxstr to PAGE_SIZE Daniel De Graaf
2015-05-27 8:13 ` Ian Campbell [this message]
2015-05-26 18:13 ` [PATCH 3/3] libxc: add missing xc_hypercall_bounce_pre calls Daniel De Graaf
2015-05-27 8:12 ` Ian Campbell
2015-05-27 8:13 ` [PATCH 1/3] flask/policy: updates from osstest runs Ian Campbell
2015-06-03 10:34 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432714431.14664.154.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.