From: Joe Perches <joe@perches.com>
To: "Harisangam, Sharvari (S.)" <sharisan@visteon.com>
Cc: "forest@alittletooquiet.net" <forest@alittletooquiet.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"tvboxspy@gmail.com" <tvboxspy@gmail.com>,
"gclement@baobob.org" <gclement@baobob.org>,
"haticeerturk27@gmail.com" <haticeerturk27@gmail.com>,
"mahfouz.saif.elyazal@gmail.com" <mahfouz.saif.elyazal@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable
Date: Thu, 28 May 2015 01:15:40 -0700 [thread overview]
Message-ID: <1432800940.2846.207.camel@perches.com> (raw)
In-Reply-To: <20150528061002.GA19430@ubuntu>
On Thu, 2015-05-28 at 06:10 +0000, Harisangam, Sharvari (S.) wrote:
> Modified the if-else statements to remove unnecessary comparisons.
> This change was detected with the help of coccinelle tool
Your commit subject implies you are doing this for the
directory, not a single file.
If you are going to do this, please do it for all files
in the directory.
$ git grep -w -E "if\s*\(.*(true|false)" drivers/staging/vt6655/
drivers/staging/vt6655/card.c: if (pDevice->bRadioOff == true)
drivers/staging/vt6655/card.c: if (pDevice->bRadioControlOff == true) {
drivers/staging/vt6655/card.c: if (pDevice->bHWRadioOff == true)
drivers/staging/vt6655/card.c: if (pDevice->bRadioControlOff == true)
drivers/staging/vt6655/card.c: if (pDevice->bRadioOff == false) {
drivers/staging/vt6655/rxtx.c: if (bRTS == true) {/* RTS_need */
drivers/staging/vt6655/rxtx.c: if (bRTS == true) {/* RTS_need */
drivers/staging/vt6655/rxtx.c: if (bRTS == true) {
drivers/staging/vt6655/rxtx.c: if (bRTS == true) { /* RTS_need */
next prev parent reply other threads:[~2015-05-28 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 6:10 [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable Harisangam, Sharvari (S.)
2015-05-28 8:15 ` Joe Perches [this message]
2015-05-31 1:32 ` gregkh
-- strict thread matches above, loose matches on Subject: below --
2015-05-25 12:22 Harisangam, Sharvari (S.)
2015-05-26 5:05 ` Sudip Mukherjee
2015-05-27 12:07 ` Harisangam, Sharvari (S.)
2015-05-28 5:10 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432800940.2846.207.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gclement@baobob.org \
--cc=gregkh@linuxfoundation.org \
--cc=haticeerturk27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=sharisan@visteon.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.