All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com
Subject: Re: [PATCH OSSTEST 0/5] Debian Jessie patches
Date: Thu, 28 May 2015 11:28:57 +0100	[thread overview]
Message-ID: <1432808937.14664.298.camel@citrix.com> (raw)
In-Reply-To: <1432144588-2102-1-git-send-email-wei.liu2@citrix.com>

On Wed, 2015-05-20 at 18:56 +0100, Wei Liu wrote:
> I worked a little bit on upgrading Osstest to Jessie a few months ago but
> dropped the ball. Here are the patches I wrote.

With the recent change to support submenus I find I now need the below,
I think update-grub on Jessie must include some sort of
whitespace/reindent functionality compared with Wheezy.

----8>-----

>From 98079d6eb0a93c12e5e65c999bf87b5364b300bc Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@citrix.com>
Date: Thu, 28 May 2015 09:24:51 +0100
Subject: [PATCH] Debian: grub2: Allow submenu and menuentry items to be
 indented.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 Osstest/Debian.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 0bf108b..16ea68b 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -444,12 +444,12 @@ sub setupboot_grub2 ($$$$) {
             if (m/^function.*\{/) {
                 $entry= { StartLine => $. };
             }
-            if (m/^menuentry\s+[\'\"](.*)[\'\"].*\{\s*$/) {
+            if (m/^\s*menuentry\s+[\'\"](.*)[\'\"].*\{\s*$/) {
                 die $entry->{StartLine} if $entry;
                 $entry= { Title => $1, StartLine => $., MenuEntryPath => join ">", @offsets };
                 $offsets[$#offsets]++;
             }
-            if (m/^submenu\s+[\'\"](.*)[\'\"].*\{\s*$/) {
+            if (m/^\s*submenu\s+[\'\"](.*)[\'\"].*\{\s*$/) {
                 $submenu={ StartLine =>$., MenuEntryPath => join ">", @offsets };
                 push @offsets,(0);
             }
-- 
2.1.4

      parent reply	other threads:[~2015-05-28 10:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 17:56 [PATCH OSSTEST 0/5] Debian Jessie patches Wei Liu
2015-05-20 17:56 ` [PATCH OSSTEST 1/5] mg-debian-installer-update: use new url for armhf packages Wei Liu
2015-05-21 15:04   ` Ian Campbell
2015-05-20 17:56 ` [PATCH OSSTEST 2/5] Debian.pm: install grub to default device Wei Liu
2015-05-20 17:56 ` [PATCH OSSTEST 3/5] Cope with Jessie's d-i vg name Wei Liu
2015-05-21 15:10   ` Ian Campbell
2015-05-21 16:04     ` Wei Liu
2015-05-21 16:15       ` Ian Campbell
2015-05-21 16:24         ` Wei Liu
2015-06-12 13:39         ` Ian Jackson
2015-05-20 17:56 ` [PATCH OSSTEST 4/5] ts-xen-build-prep: install libnl-route-3-dev on Jessie Wei Liu
2015-05-20 17:56 ` [PATCH OSSTEST 5/5] ts-xen-build-prep: install libc6-dev-i386 for jessie Wei Liu
2015-05-20 18:04 ` [PATCH OSSTEST 0/5] Debian Jessie patches Wei Liu
2015-06-10  9:50   ` Ian Campbell
2015-06-12 20:43     ` Wei Liu
2015-06-15  8:29       ` Wei Liu
2015-06-15  8:37         ` Ian Campbell
2015-06-15  8:41           ` Ian Campbell
2015-05-28 10:28 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432808937.14664.298.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.