All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	ktkhai@parallels.com
Subject: Re: sched_setscheduler() vs idle_balance() race
Date: Thu, 28 May 2015 14:32:45 +0200	[thread overview]
Message-ID: <1432816365.3237.168.camel@gmail.com> (raw)
In-Reply-To: <20150528120651.GH3644@twins.programming.kicks-ass.net>

On Thu, 2015-05-28 at 14:06 +0200, Peter Zijlstra wrote:
> On Thu, May 28, 2015 at 02:04:21PM +0200, Mike Galbraith wrote:
> > On Thu, 2015-05-28 at 13:51 +0200, Peter Zijlstra wrote:
> 
> > > Which is exactly the hole you mean, right?
> > 
> > Yeah, but that hole is way older than dl.  Box falling into it is
> > running SLE11, which is.. well, still somewhat resembles 3.0.
> 
> Oh sure, that patch just recognised there was a hole there and put a
> comment in. We further failed to spot the fail you just did.

Happens.  Even with a perfect trap set and triggered, evidence right
under my nose, I'm so used to that code that I didn't see the obvious
until I took a second look.. and had that 'you dumbass' moment ;-)

	-Mike


  reply	other threads:[~2015-05-28 12:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28  7:43 sched_setscheduler() vs idle_balance() race Mike Galbraith
2015-05-28 11:51 ` Peter Zijlstra
2015-05-28 12:04   ` Mike Galbraith
2015-05-28 12:06     ` Peter Zijlstra
2015-05-28 12:32       ` Mike Galbraith [this message]
2015-05-28 13:53 ` Peter Zijlstra
2015-05-28 14:54   ` Mike Galbraith
2015-05-28 15:24     ` Peter Zijlstra
2015-05-29 18:30       ` Mike Galbraith
2015-05-29 18:48         ` Mike Galbraith
2015-06-01  8:14           ` Peter Zijlstra
2015-06-01  8:16         ` Peter Zijlstra
2015-06-01 10:00           ` Mike Galbraith
2015-05-28 16:59   ` Kirill Tkhai
2015-05-30 13:08   ` Mike Galbraith
2015-05-31  6:39     ` Mike Galbraith
2015-06-01  8:24       ` Peter Zijlstra
2015-06-01  8:19     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432816365.3237.168.camel@gmail.com \
    --to=umgwanakikbuti@gmail.com \
    --cc=ktkhai@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.