From: Joe Perches <joe@perches.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map()
Date: Thu, 28 May 2015 11:30:09 -0700 [thread overview]
Message-ID: <1432837809.1556.3.camel@perches.com> (raw)
In-Reply-To: <1432817579-4720-1-git-send-email-yamada.masahiro@socionext.com>
On Thu, 2015-05-28 at 21:52 +0900, Masahiro Yamada wrote:
> There are two types for pinctrl maps: pinmux and pinconfig
> This debug message shows the number of maps of both types.
> The string "pinmux map" is not precise. Let's say "pinctrl map"
> instead.
[]
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
[]
> @@ -1115,7 +1115,7 @@ int pinctrl_register_map(struct pinctrl_map const *maps, unsigned num_maps,
> int i, ret;
> struct pinctrl_maps *maps_node;
>
> - pr_debug("add %d pinmux maps\n", num_maps);
> + pr_debug("add %d pinctrl maps\n", num_maps);
You might want to fix the %d/%u mismatch too
next prev parent reply other threads:[~2015-05-28 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 12:52 [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map() Masahiro Yamada
2015-05-28 18:30 ` Joe Perches [this message]
2015-06-02 11:33 ` Linus Walleij
2015-06-02 12:16 ` Masahiro Yamada
2015-06-08 13:33 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432837809.1556.3.camel@perches.com \
--to=joe@perches.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.