From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755215AbbE1XKG (ORCPT ); Thu, 28 May 2015 19:10:06 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:34980 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755163AbbE1XJq (ORCPT ); Thu, 28 May 2015 19:09:46 -0400 From: Riley Andrews To: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Riley Andrews , devel@driverdev.osuosl.org Subject: [PATCH 02/13] android: binder: fix duplicate error return. Date: Thu, 28 May 2015 16:08:20 -0700 Message-Id: <1432854511-33320-3-git-send-email-riandrews@android.com> X-Mailer: git-send-email 2.2.0.rc0.207.ga3a616c In-Reply-To: <1432854511-33320-1-git-send-email-riandrews@android.com> References: <1432854511-33320-1-git-send-email-riandrews@android.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Duplicate errors can be returned to userspace when the thread error code is left set when the read buffer runs out of space. Signed-off-by: Riley Andrews --- drivers/android/binder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index f1a26d9..2069759 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -2167,9 +2167,9 @@ retry: return -EFAULT; ptr += sizeof(uint32_t); binder_stat_br(proc, thread, thread->return_error2); + thread->return_error2 = BR_OK; if (ptr == end) goto done; - thread->return_error2 = BR_OK; } if (put_user(thread->return_error, (uint32_t __user *)ptr)) return -EFAULT; -- 2.2.0.rc0.207.ga3a616c