From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755288AbbE1XLY (ORCPT ); Thu, 28 May 2015 19:11:24 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:34743 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755190AbbE1XJ4 (ORCPT ); Thu, 28 May 2015 19:09:56 -0400 From: Riley Andrews To: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Riley Andrews , devel@driverdev.osuosl.org Subject: [PATCH 08/13] android: binder: add function for logging failed transactions Date: Thu, 28 May 2015 16:08:26 -0700 Message-Id: <1432854511-33320-9-git-send-email-riandrews@android.com> X-Mailer: git-send-email 2.2.0.rc0.207.ga3a616c In-Reply-To: <1432854511-33320-1-git-send-email-riandrews@android.com> References: <1432854511-33320-1-git-send-email-riandrews@android.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add another helper function that adds log entries to failed log. Signed-off-by: Riley Andrews --- drivers/android/binder.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index ed94121..f7f2217 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -211,6 +211,16 @@ static struct binder_transaction_log_entry *binder_transaction_log_add( return e; } +static void binder_transaction_log_add_copy( + struct binder_transaction_log *log, + struct binder_transaction_log_entry *entry) +{ + struct binder_transaction_log_entry *failed; + + failed = binder_transaction_log_add(log); + *failed = *entry; +} + struct binder_work { struct list_head entry; enum { @@ -1827,13 +1837,7 @@ err_invalid_target_handle: proc->pid, thread->pid, return_error, (u64)tr->data_size, (u64)tr->offsets_size); - { - struct binder_transaction_log_entry *fe; - - fe = binder_transaction_log_add(&binder_transaction_log_failed); - *fe = *e; - } - + binder_transaction_log_add_copy(&binder_transaction_log_failed, e); BUG_ON(thread->return_error != BR_OK); if (in_reply_to) { thread->return_error = BR_TRANSACTION_COMPLETE; -- 2.2.0.rc0.207.ga3a616c