From mboxrd@z Thu Jan 1 00:00:00 1970 From: pebolle@tiscali.nl (Paul Bolle) Date: Fri, 29 May 2015 09:14:49 +0200 Subject: [RFC PATCH 1/5] livepatch: ftrace: arm64: Add support for DYNAMIC_FTRACE_WITH_REGS In-Reply-To: <1432792265-24076-2-git-send-email-huawei.libin@huawei.com> References: <1432792265-24076-1-git-send-email-huawei.libin@huawei.com> <1432792265-24076-2-git-send-email-huawei.libin@huawei.com> Message-ID: <1432883689.3551.3.camel@x220> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2015-05-28 at 13:51 +0800, Li Bin wrote: > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > select HAVE_DYNAMIC_FTRACE > + select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE What's the point of "if HAVE_DYNAMIC_FTRACE" here? That test should always evaluate to true, because HAVE_DYNAMIC_FTRACE is also selected. Paul Bolle From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbbE2HPG (ORCPT ); Fri, 29 May 2015 03:15:06 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:48536 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754653AbbE2HO7 (ORCPT ); Fri, 29 May 2015 03:14:59 -0400 Message-ID: <1432883689.3551.3.camel@x220> Subject: Re: [RFC PATCH 1/5] livepatch: ftrace: arm64: Add support for DYNAMIC_FTRACE_WITH_REGS From: Paul Bolle To: Li Bin Cc: rostedt@goodmis.org, mingo@kernel.org, jpoimboe@redhat.com, sjenning@redhat.com, jkosina@suse.cz, vojtech@suse.cz, catalin.marinas@arm.com, will.deacon@arm.com, masami.hiramatsu.pt@hitachi.com, live-patching@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, felix.yang@huawei.com, guohanjun@huawei.com, xiexiuqi@huawei.com Date: Fri, 29 May 2015 09:14:49 +0200 In-Reply-To: <1432792265-24076-2-git-send-email-huawei.libin@huawei.com> References: <1432792265-24076-1-git-send-email-huawei.libin@huawei.com> <1432792265-24076-2-git-send-email-huawei.libin@huawei.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-05-28 at 13:51 +0800, Li Bin wrote: > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > select HAVE_DYNAMIC_FTRACE > + select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE What's the point of "if HAVE_DYNAMIC_FTRACE" here? That test should always evaluate to true, because HAVE_DYNAMIC_FTRACE is also selected. Paul Bolle