Re: [PATCH 0/3] Add const to various core functions

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 3513 bytes --]

On Fri, 2015-05-29 at 00:13 -0400, ira.weiny wrote:
> On Thu, May 21, 2015 at 04:40:21PM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> > From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Doug, Jason,
> 
> Were there any issues with these clean ups?

I haven't gotten to them yet.  Your 14 patch OPA addition and this were
on my queue for getting to relatively soonish.  I *thought* this touched
stuff that your 14 patch set also touched and so thought it needed to be
on top of it, so that's part of the reason why I hadn't even looked at
it yet (these emails are part of the "still new and unread" emails in my
Inbox that seem to never get to 0 ;-).

> I think they stand on their own but I can add them to the OPA series if you
> prefer.

Double check that they stand on their own.  If they do, I'll review them
separately.

> Ira
> 
> > 
> > In order to support some of Jason's comments to add const to the functions I am
> > adding for OPA the following patches clean up the call trees of the currently
> > defined functions.
> > 
> > They stand on their own as clean up patches.  Therefore, I am submitting them
> > separately from the OPA patches.
> > 
> > Ira Weiny (3):
> >   IB/core: Add const to RDMA helpers
> >   IB/core: Add const to device process_mad
> >   IB/core: Add const to agent_send_response
> > 
> >  drivers/infiniband/core/addr.c                |  4 +--
> >  drivers/infiniband/core/agent.c               |  8 +++---
> >  drivers/infiniband/core/agent.h               |  4 +--
> >  drivers/infiniband/core/cache.c               |  8 +++---
> >  drivers/infiniband/core/verbs.c               |  9 ++++---
> >  drivers/infiniband/hw/amso1100/c2_provider.c  |  6 ++---
> >  drivers/infiniband/hw/cxgb3/iwch_provider.c   |  6 ++---
> >  drivers/infiniband/hw/cxgb4/provider.c        |  5 ++--
> >  drivers/infiniband/hw/ehca/ehca_iverbs.h      |  4 +--
> >  drivers/infiniband/hw/ehca/ehca_sqp.c         |  4 +--
> >  drivers/infiniband/hw/ipath/ipath_mad.c       |  8 +++---
> >  drivers/infiniband/hw/ipath/ipath_verbs.h     |  6 ++---
> >  drivers/infiniband/hw/mlx4/mad.c              | 21 ++++++++-------
> >  drivers/infiniband/hw/mlx4/mlx4_ib.h          |  8 +++---
> >  drivers/infiniband/hw/mlx5/mad.c              |  8 +++---
> >  drivers/infiniband/hw/mlx5/mlx5_ib.h          |  8 +++---
> >  drivers/infiniband/hw/mthca/mthca_cmd.c       |  4 +--
> >  drivers/infiniband/hw/mthca/mthca_cmd.h       |  4 +--
> >  drivers/infiniband/hw/mthca/mthca_dev.h       |  6 ++---
> >  drivers/infiniband/hw/mthca/mthca_mad.c       | 10 +++----
> >  drivers/infiniband/hw/nes/nes_verbs.c         |  4 +--
> >  drivers/infiniband/hw/ocrdma/ocrdma_ah.c      |  6 ++---
> >  drivers/infiniband/hw/ocrdma/ocrdma_ah.h      |  6 ++---
> >  drivers/infiniband/hw/qib/qib_mad.c           | 10 +++----
> >  drivers/infiniband/hw/qib/qib_verbs.h         |  4 +--
> >  drivers/net/ethernet/mellanox/mlx5/core/mad.c |  2 +-
> >  include/linux/mlx5/driver.h                   |  2 +-
> >  include/rdma/ib_addr.h                        |  6 ++---
> >  include/rdma/ib_cache.h                       |  8 +++---
> >  include/rdma/ib_verbs.h                       | 39 ++++++++++++++-------------
> >  30 files changed, 116 insertions(+), 112 deletions(-)
> > 
> > -- 
> > 1.8.2
> > 


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]