Re: ACPI shutdown unreliable with win7?

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2015-05-29 at 14:04 +0100, Jan Beulich wrote:
> >>> On 29.05.15 at 14:54, <ian.campbell@citrix.com> wrote:
> > On Fri, 2015-05-22 at 10:08 +0100, Ian Campbell wrote:
> >> If win7 doesn't shutdown given a power button request I'd be more
> >> inclined to remove the setting in osstest for those flights and let
> >> guest-stop go back to being never pass than to start making such changes
> >> to the VM config which I think would probably break the preceding
> >> suspend and migration tests (which aren't completely reliable, but are
> >> far more so than this shutdown one).
> > 
> > Does anyone have any ideas here or shall I propose:
> 
> Unless we have a way to make an adjustment inside the guest for the
> power button to gain "shutdown" meaning, I think there's no alternative
> to the change below.

The strange this is that it does work _sometimes_, either by complete
coincidence or because there is something non-deterministic about how
Win7 reacts to this ACPI event.

Does anyone know which setting we would want to change? In particular it
would be good if I knew what to look for to check the current status...

> 
> Jan
> 
> > -----8>--------------
> > 
> > From 2d1b814e65676c3cf56ce2e569491953607f53f7 Mon Sep 17 00:00:00 2001
> > From: Ian Campbell <ian.campbell@citrix.com>
> > Date: Fri, 29 May 2015 13:51:33 +0100
> > Subject: [PATCH] Turn off acpi_shutdown for windows 7
> > 
> > As described in <1432284841.10746.136.camel@citrix.com> /
> > http://lists.xen.org/archives/html/xen-devel/2015-05/msg03016.html 
> > Windows 7 does not appear to reliably actually shutdown when asked to
> > via the ACPI power button.
> > 
> > Once this patch is applied some force pushes will likely be needed in
> > order for this to not appear as a regression.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>
> > Cc: Paul Durrant <paul.durrant@citrix.com>
> > Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
> > Cc: Jan Beulich <JBeulich@suse.com>
> > ---
> > Alternatively could make it an allowed/non-blocking failure?
> > ---
> >  make-flight | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/make-flight b/make-flight
> > index 8a1fceb..5120891 100755
> > --- a/make-flight
> > +++ b/make-flight
> > @@ -206,7 +206,6 @@ do_hvm_win7_x64_tests () {
> >    job_create_test test-$xenarch$kern-$dom0arch-xl$qemuu_suffix-win7-amd64 \
> >              test-win xl $xenarch $dom0arch $qemuu_runvar \
> >              win_image=win7-x64.iso \
> > -            win_acpi_shutdown=true \
> >              all_hostflags=$most_hostflags,hvm
> >  }
> >  
> > -- 
> > 2.1.4
> 
> 
>