Re: ACPI shutdown unreliable with win7?

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2015-05-29 at 15:31 +0100, Andrew Cooper wrote:
> On 29/05/15 15:00, Ian Campbell wrote:
> > On Fri, 2015-05-29 at 14:28 +0100, Jan Beulich wrote:
> >>>>> On 29.05.15 at 15:14, <andrew.cooper3@citrix.com> wrote:
> >>> On 29/05/15 14:04, Jan Beulich wrote:
> >>>>>>> On 29.05.15 at 14:54, <ian.campbell@citrix.com> wrote:
> >>>>> On Fri, 2015-05-22 at 10:08 +0100, Ian Campbell wrote:
> >>>>>> If win7 doesn't shutdown given a power button request I'd be more
> >>>>>> inclined to remove the setting in osstest for those flights and let
> >>>>>> guest-stop go back to being never pass than to start making such changes
> >>>>>> to the VM config which I think would probably break the preceding
> >>>>>> suspend and migration tests (which aren't completely reliable, but are
> >>>>>> far more so than this shutdown one).
> >>>>> Does anyone have any ideas here or shall I propose:
> >>>> Unless we have a way to make an adjustment inside the guest for the
> >>>> power button to gain "shutdown" meaning, I think there's no alternative
> >>>> to the change below.
> >>> You can avoid advertising S3/S4 in the ACPI tables, which iirc causes
> >>> the same alteration to happen.
> >>>
> >>> Hvmloader uses the platform/acpi_s{3,4} booleans to control whether the
> >>> relevant SSDTs are exposed.
> >> Which libxl even has settings for. That would perhaps be a better first
> >> try than disabling ACPI shutdown.
> > I've mentioned it at least twice now but nobody seems to think it is of
> > note that even with the current settings it does the right thing about 1
> > time in 10? Is Win7 really expected to behave so randomly here? 
> 
> Windows is far from bug free, and also a black box.  I really cannot
> answer whether this is intended behaviour or not.
> 
> >
> > Also, when the test fails the guest is also not hibernating either.
> >
> > Plus I've queried the impact of change the ACPI s3/s4 settings on the
> > save/restore/migrate tests in the flight more than once and nobody has
> > responded to that either.
> 
> save/restore/migrate necessarily need PV drivers inside the guest, and
> installing PV drivers should set the sane defaults inside the guest.
> 
> What does OSSTest do with PV drivers?

Nothing AFAIK, unless they are baked into the ISOs we take from the
XenRT folks (which I think is not the case).

Yet our s/r/m tests of these guests do pass (mostly), I believe because
they end up leveraging HVM s3 but I might be wrong.

Ian.