From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: ACPI shutdown unreliable with win7? Date: Fri, 29 May 2015 15:38:24 +0100 Message-ID: <1432910304.15036.55.camel@citrix.com> References: <1432284841.10746.136.camel@citrix.com> <555EEFD8.8020306@citrix.com> <1432285699.10746.147.camel@citrix.com> <1432904091.15036.27.camel@citrix.com> <55688018020000780007F06C@mail.emea.novell.com> <55686631.7020606@citrix.com> <55688593020000780007F0BD@mail.emea.novell.com> <1432908001.15036.40.camel@citrix.com> <55687842.7050809@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55687842.7050809@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Paul Durrant , Ian Jackson , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On Fri, 2015-05-29 at 15:31 +0100, Andrew Cooper wrote: > On 29/05/15 15:00, Ian Campbell wrote: > > On Fri, 2015-05-29 at 14:28 +0100, Jan Beulich wrote: > >>>>> On 29.05.15 at 15:14, wrote: > >>> On 29/05/15 14:04, Jan Beulich wrote: > >>>>>>> On 29.05.15 at 14:54, wrote: > >>>>> On Fri, 2015-05-22 at 10:08 +0100, Ian Campbell wrote: > >>>>>> If win7 doesn't shutdown given a power button request I'd be more > >>>>>> inclined to remove the setting in osstest for those flights and let > >>>>>> guest-stop go back to being never pass than to start making such changes > >>>>>> to the VM config which I think would probably break the preceding > >>>>>> suspend and migration tests (which aren't completely reliable, but are > >>>>>> far more so than this shutdown one). > >>>>> Does anyone have any ideas here or shall I propose: > >>>> Unless we have a way to make an adjustment inside the guest for the > >>>> power button to gain "shutdown" meaning, I think there's no alternative > >>>> to the change below. > >>> You can avoid advertising S3/S4 in the ACPI tables, which iirc causes > >>> the same alteration to happen. > >>> > >>> Hvmloader uses the platform/acpi_s{3,4} booleans to control whether the > >>> relevant SSDTs are exposed. > >> Which libxl even has settings for. That would perhaps be a better first > >> try than disabling ACPI shutdown. > > I've mentioned it at least twice now but nobody seems to think it is of > > note that even with the current settings it does the right thing about 1 > > time in 10? Is Win7 really expected to behave so randomly here? > > Windows is far from bug free, and also a black box. I really cannot > answer whether this is intended behaviour or not. > > > > > Also, when the test fails the guest is also not hibernating either. > > > > Plus I've queried the impact of change the ACPI s3/s4 settings on the > > save/restore/migrate tests in the flight more than once and nobody has > > responded to that either. > > save/restore/migrate necessarily need PV drivers inside the guest, and > installing PV drivers should set the sane defaults inside the guest. > > What does OSSTest do with PV drivers? Nothing AFAIK, unless they are baked into the ISOs we take from the XenRT folks (which I think is not the case). Yet our s/r/m tests of these guests do pass (mostly), I believe because they end up leveraging HVM s3 but I might be wrong. Ian.