From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Amir Vadai <amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Tal Alon <talal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH for-next V1 10/11] IB/mlx4: Add timestamp_mask and hca_core_clock to query_device
Date: Fri, 29 May 2015 12:41:24 -0400 [thread overview]
Message-ID: <1432917684.114391.98.camel@redhat.com> (raw)
In-Reply-To: <1432220202-9834-11-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]
On Thu, 2015-05-21 at 17:56 +0300, Or Gerlitz wrote:
> From: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> mlx4 needs to report the number of supported timestamp
> bits (mask) and the hca_core_clock frequency.
>
> Signed-off-by: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> drivers/infiniband/hw/mlx4/main.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
> index ef211c8..a5a90c4 100644
> --- a/drivers/infiniband/hw/mlx4/main.c
> +++ b/drivers/infiniband/hw/mlx4/main.c
> @@ -233,6 +233,8 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
> props->max_total_mcast_qp_attach = props->max_mcast_qp_attach *
> props->max_mcast_grp;
> props->max_map_per_fmr = dev->dev->caps.max_fmr_maps;
> + props->hca_core_clock = dev->dev->caps.hca_core_clock;
> + props->timestamp_mask = 0xFFFFFFFFFFFFULL;
>
> out:
> kfree(in_mad);
Or, please squash 8, 9, and 10 to a single patch. They all are "add
support for timestamping to mlx4" but without squashing them together,
the support they add is broken/partial.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-29 16:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 14:56 [PATCH for-next V1 00/11] Add completion timestamping support Or Gerlitz
[not found] ` <1432220202-9834-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-21 14:56 ` [PATCH for-next V1 01/11] IB/core: Change provider's API of create_cq to be extendible Or Gerlitz
2015-05-21 14:56 ` [PATCH for-next V1 02/11] IB/core: Change ib_create_cq to use struct ib_cq_init_attr Or Gerlitz
2015-05-21 14:56 ` [PATCH for-next V1 03/11] IB/core: Add CQ creation time-stamping flag Or Gerlitz
[not found] ` <1432220202-9834-4-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-29 16:47 ` Doug Ledford
[not found] ` <1432918022.114391.102.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-29 19:16 ` Steve Wise
2015-05-21 14:56 ` [PATCH for-next V1 04/11] IB/core: Extend ib_uverbs_create_cq Or Gerlitz
2015-05-21 14:56 ` [PATCH for-next V1 05/11] IB/core: Add timestamp_mask and hca_core_clock to query_device Or Gerlitz
2015-05-21 14:56 ` [PATCH for-next V1 06/11] IB/core: Pass hardware specific data in query_device Or Gerlitz
2015-05-21 14:56 ` [PATCH for-next V1 07/11] IB/mlx4: Add mmap call to map the hardware clock Or Gerlitz
2015-05-21 14:56 ` [PATCH for-next V1 08/11] IB/mlx4: Support extended create_cq and query_device uverbs Or Gerlitz
2015-05-21 14:56 ` [PATCH for-next V1 09/11] IB/mlx4: Add support for timestamp in cq creation Or Gerlitz
2015-05-21 14:56 ` [PATCH for-next V1 10/11] IB/mlx4: Add timestamp_mask and hca_core_clock to query_device Or Gerlitz
[not found] ` <1432220202-9834-11-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-29 16:41 ` Doug Ledford [this message]
[not found] ` <1432917684.114391.98.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-30 20:49 ` Or Gerlitz
2015-05-21 14:56 ` [PATCH for-next V1 11/11] IB/mlx4: Return hca core clock's offset in query_device vendor's data Or Gerlitz
2015-05-23 4:23 ` [PATCH for-next V1 00/11] Add completion timestamping support Or Gerlitz
2015-05-28 21:41 ` Steve Wise
[not found] ` <55678BA6.4050503-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2015-05-29 15:47 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432917684.114391.98.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=talal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.