From: Ian Campbell <ian.campbell@citrix.com>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel <xen-devel@lists.xen.org>,
Meng Xu <xumengpanda@gmail.com>, Meng Xu <mengxu@cis.upenn.edu>,
Jan Beulich <JBeulich@suse.com>, Chong Li <lichong659@gmail.com>,
Dagaen Golomb <dgolomb@seas.upenn.edu>
Subject: Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
Date: Mon, 1 Jun 2015 10:44:05 +0100 [thread overview]
Message-ID: <1433151845.15036.84.camel@citrix.com> (raw)
In-Reply-To: <556C23DF.3040903@eu.citrix.com>
On Mon, 2015-06-01 at 10:20 +0100, George Dunlap wrote:
> On 06/01/2015 10:06 AM, Andrew Cooper wrote:
> > On 01/06/15 09:58, Jan Beulich wrote:
> >>>>> On 01.06.15 at 10:50, <george.dunlap@eu.citrix.com> wrote:
> >>> On 06/01/2015 09:48 AM, Ian Campbell wrote:
> >>>> On Mon, 2015-06-01 at 09:36 +0100, George Dunlap wrote:
> >>>>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
> >>>>> ---
> >>>>> CC: Ian Campbell <ian.campbell@citrix.com>
> >>>>> CC: Wei Liu <wei.liu@citrix.com>
> >>>> Most people put the Cc about the cut (---) which is fine too. It means
> >>>> the history ends up recording who was copied on the patch, which isn't
> >>>> necessarily a bad thing.
> >>> Right -- I would have thought that was useless information cluttering up
> >>> the history, but I can see how it might actually be useful. Should I
> >>> start putting my CC's above the ---? :-)
> >> And should I stop dropping them even when above the --- for
> >> commit, which so far I've been doing as I don't consider this
> >> particularly useful information (other then e.g. who might have
> >> commented on a change without it being recorded in an Acked-by
> >> or Reviewed-by tag)?
> >
> > Is the CC list useful to keep in history? It ends up being the list of
> > people who didn't respond to it before it got committed (or
> > ignored/missed the email entirely).
> >
> > It is the $FOO'd-by tags which are important when it comes to judging
> > the acceptability of a patch.
>
> OK, well that's 3 of us so far who think it's sort of useless, including
> someone who things it's useless enough to spend the effort deleting
> them. Maybe we can leave the bike shed the color it is at the moment. ;-)
I used to delete them, but it was tiresome and seemed like a waste of
effort since, whatever the magnitude, the information content isn't 0
and they are harmless.
Ian.
prev parent reply other threads:[~2015-06-01 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 23:59 [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler Chong Li
2015-05-26 8:59 ` Ian Campbell
2015-05-29 11:15 ` Dario Faggioli
2015-05-29 14:40 ` Meng Xu
2015-06-01 8:36 ` George Dunlap
2015-06-01 8:48 ` Ian Campbell
2015-06-01 8:50 ` George Dunlap
2015-06-01 8:57 ` Ian Campbell
2015-06-01 8:58 ` Jan Beulich
2015-06-01 9:06 ` Andrew Cooper
2015-06-01 9:20 ` George Dunlap
2015-06-01 9:44 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433151845.15036.84.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=mengxu@cis.upenn.edu \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.