All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, ian.jackson@eu.citrix.com
Subject: Re: [PATCH OSSTEST] Toolstack: Do not pass -F to xm shutdown (Was: Re: [xen-4.2-testing test] 57630: regressions - FAIL)
Date: Mon, 1 Jun 2015 11:02:18 +0100	[thread overview]
Message-ID: <1433152938.15036.92.camel@citrix.com> (raw)
In-Reply-To: <1433147647.15036.76.camel@citrix.com>

On Mon, 2015-06-01 at 09:34 +0100, Ian Campbell wrote:
> From aa79bd958fe42da2876fd76e61468c183a7fabdc Mon Sep 17 00:00:00 2001
> From: Ian Campbell <ian.campbell@citrix.com>
> Date: Mon, 1 Jun 2015 09:32:37 +0100
> Subject: [PATCH] Toolstack: Do not pass -F to xm shutdown
> 
> This is a feature of xl only.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

With Ian being away for a bit and this blocking testing of older
branches which contain xend I've pushed this to osstest's pretest
branch.

Ian.

> ---
>  Osstest/Toolstack/xl.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Osstest/Toolstack/xl.pm b/Osstest/Toolstack/xl.pm
> index dd12ae1..23328d3 100644
> --- a/Osstest/Toolstack/xl.pm
> +++ b/Osstest/Toolstack/xl.pm
> @@ -56,7 +56,7 @@ sub shutdown_wait ($$$) {
>      my $ho = $self->{Host};
>      my $gn = $gho->{Name};
>      my $acpi_fallback = guest_var($gho,'acpi_shutdown','false') eq 'true'
> -	? "F" : "";
> +	&& $self->{Name} eq 'xl' ? "F" : "";
>      target_cmd_root($ho,"$self->{_Command} shutdown -w${acpi_fallback} $gn", $timeout);
>  }
>  

      parent reply	other threads:[~2015-06-01 10:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-31 22:57 [xen-4.2-testing test] 57630: regressions - FAIL osstest service user
2015-06-01  7:56 ` Jan Beulich
2015-06-01  8:34   ` [PATCH OSSTEST] Toolstack: Do not pass -F to xm shutdown (Was: Re: [xen-4.2-testing test] 57630: regressions - FAIL) Ian Campbell
2015-06-01  9:21     ` Jan Beulich
2015-06-01  9:42       ` Ian Campbell
2015-06-01  9:47         ` Jan Beulich
2015-06-01 10:02     ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433152938.15036.92.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.