From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3 1/2] efi: Fix allocation problems if
 ExitBootServices() fails
Date: Mon, 1 Jun 2015 12:24:11 +0100
Message-ID: <1433157851.15036.122.camel@citrix.com>
References: <1433153878-32199-1-git-send-email-ross.lagerwall@citrix.com>
	<556C59B8020000780007FABA@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <556C59B8020000780007FABA@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, roy.franz@linaro.org
Cc: Keir Fraser <keir@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org, Ross Lagerwall <ross.lagerwall@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-06-01 at 12:10 +0100, Jan Beulich wrote:
> >>> On 01.06.15 at 12:17, <ross.lagerwall@citrix.com> wrote:
> > If calling ExitBootServices() fails, the required memory map size may
> > have increased. When initially allocating the memory map, allocate a
> > slightly larger buffer (by an arbitrary 8 entries) to fix this.
> > 
> > The ARM code path was already allocating a larger buffer than required,
> > so this moves the code to be common for all architectures.
> > 
> > This was seen on the following machine when using the iscsidxe UEFI
> > driver. The machine would consistently fail the first call to
> > ExitBootServices().
> > System Information
> >         Manufacturer: Supermicro
> >         Product Name: X10SLE-F/HF
> > BIOS Information
> >         Vendor: American Megatrends Inc.
> >         Version: 2.00
> >         Release Date: 04/24/2014
> > 
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> 
> Provided ARM folks are happy with the reduced increase,

Hi Roy,

This patch[0] turns a +PAGE_SIZE in efi_arch_allocate_mmap_buffer into a
"8 * efi_mdesc_size" in the common code.

The +PAGE_SIZE came from [1] so I think it is as arbitrary as the
+8*sizeof here.

IOW this change looks ok to me, what do you think?

Thanks,
Ian.

[0] http://lists.xen.org/archives/html/xen-devel/2015-06/msg00067.html
[1] http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=932881d953476444ed934c94dbc098c0fefb4d77

> Acked-by: Jan Beulich <jbeulich@suse.com>
>