From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:49052 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293AbbFCBZS (ORCPT ); Tue, 2 Jun 2015 21:25:18 -0400 Subject: Patch "Revert "ALSA: hda - Add mute-LED mode control to Thinkpad"" has been added to the 4.0-stable tree To: tiwai@suse.de, gregkh@linuxfoundation.org, martin@lichtvoll.de, pali.rohar@gmail.com Cc: , From: Date: Wed, 03 Jun 2015 10:25:04 +0900 Message-ID: <1433294704956@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled Revert "ALSA: hda - Add mute-LED mode control to Thinkpad" to the 4.0-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: revert-alsa-hda-add-mute-led-mode-control-to-thinkpad.patch and it can be found in the queue-4.0 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 3530febb5c7636f6b26d15637f68296804d26491 Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Sun, 24 May 2015 08:27:52 +0200 Subject: Revert "ALSA: hda - Add mute-LED mode control to Thinkpad" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Takashi Iwai commit 3530febb5c7636f6b26d15637f68296804d26491 upstream. This reverts commit 7290006d8c0900c56d8c58428134f02c35109d17. Through the regression report, it was revealed that the tpacpi_led_set() call to thinkpad_acpi helper doesn't only toggle the mute LED but actually mutes the sound. This is contradiction to the expectation, and rather confuses user. According to Henrique, it's not trivial to judge which TP model behaves "LED-only" and which model does whatever more intrusive, as Lenovo's implementations vary model by model. So, from the safety reason, we should revert the patch for now. Reported-by: Martin Steigerwald Cc: Pali Rohár Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/thinkpad_helper.c | 1 - 1 file changed, 1 deletion(-) --- a/sound/pci/hda/thinkpad_helper.c +++ b/sound/pci/hda/thinkpad_helper.c @@ -72,7 +72,6 @@ static void hda_fixup_thinkpad_acpi(stru if (led_set_func(TPACPI_LED_MUTE, false) >= 0) { old_vmaster_hook = spec->vmaster_mute.hook; spec->vmaster_mute.hook = update_tpacpi_mute_led; - spec->vmaster_mute_enum = 1; removefunc = false; } if (led_set_func(TPACPI_LED_MICMUTE, false) >= 0) { Patches currently in stable-queue which might be from tiwai@suse.de are queue-4.0/revert-alsa-hda-add-mute-led-mode-control-to-thinkpad.patch queue-4.0/alsa-usb-audio-add-quirk-for-ms-lifecam-hd-3000.patch queue-4.0/alsa-usb-audio-add-quirk-for-ms-lifecam-studio.patch queue-4.0/alsa-hda-realtek-alc292-dock-fix-for-thinkpad-l450.patch queue-4.0/alsa-hda-add-headset-mic-quirk-for-dell-inspiron-5548.patch queue-4.0/alsa-hda-add-conexant-codecs-cx20721-cx20722-cx20723-and-cx20724.patch queue-4.0/alsa-hda-fix-noise-on-amd-radeon-290x-controller.patch queue-4.0/alsa-hda-add-headphone-quirk-for-lifebook-e752.patch