From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: RFC: making the PVH 64bit ABI as stableo Date: Wed, 3 Jun 2015 10:20:29 +0100 Message-ID: <1433323229.7108.28.camel@citrix.com> References: <556DC799.5040300@citrix.com> <556DEB9A020000780008079A@mail.emea.novell.com> <556DE352.3030703@citrix.com> <1433322031.7108.16.camel@citrix.com> <556EC3A3.6050006@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z04qo-0000Up-Fh for xen-devel@lists.xenproject.org; Wed, 03 Jun 2015 09:20:42 +0000 In-Reply-To: <556EC3A3.6050006@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Elena Ufimtseva , Lars Kurth , Stefano Stabellini , Tim Deegan , David Vrabel , Jan Beulich , xen-devel , Boris Ostrovsky , Roger Pau =?ISO-8859-1?Q?Monn=E9?= List-Id: xen-devel@lists.xenproject.org On Wed, 2015-06-03 at 10:06 +0100, Andrew Cooper wrote: > On 03/06/15 10:00, Ian Campbell wrote: > > On Tue, 2015-06-02 at 18:09 +0100, Andrew Cooper wrote: > >> * Removal of all /* TODO pvhfixme */ from the code > > I guess this is not the literal tag: > > ianc@cosworth:xen.git$ git grep -i TODO.pvhfixme xen > > ianc@cosworth:xen.git$ git grep -i TODO.*pvh xen > > ianc@cosworth:xen.git$ > > > > I think you meant: > > ianc@cosworth:xen.git$ git grep -i pvh.fixme xen > > xen/arch/x86/domain_build.c: * pvh fixme: The following doesn't map MMIO ranges when they sit above the > > xen/arch/x86/domain_build.c: * PVH Fixme: XENFEAT_supervisor_mode_kernel has been reused in PVH with a > > xen/arch/x86/hvm/vmx/vmx.c: if ( unlikely(is_pvh_vcpu(v)) /* PVH fixme */ || > > xen/arch/x86/mm/p2m-pt.c: /* pvh fixme: foreign types are only supported on ept at present */ > > xen/arch/x86/mm/p2m.c: * pvh fixme: when adding support for pvh non-hardware domains, this path must > > xen/arch/x86/mm/p2m.c: * pvh fixme: until support is added to p2m teardown code to cleanup any > > xen/arch/x86/time.c: * PVH fixme: support more tsc modes. > > xen/arch/x86/traps.c: if ( !d || !d->vcpu || !d->vcpu[0] || !is_pv_domain(d) /* PVH fixme */ ) > > xen/common/vm_event.c: /* pvh fixme: p2m_is_foreign types need addressing */ > > xen/common/vm_event.c: /* pvh fixme: p2m_is_foreign types need addressing */ > > > > Are there other variants or is this the list? > > > > > > At least one more comes to mind. > > andrewcoop@andrewcoop:/local/xen.git/xen$ git grep -i "PVH 32bitfixme" > arch/x86/domain.c:768: /* PVH 32bitfixme */ > arch/x86/hvm/hvm.c:2318: v->arch.hvm_vcpu.hcall_64bit = 1; /* > PVH 32bitfixme. */ > arch/x86/hvm/hvm.c:4898:/* PVH 32bitfixme. */ > arch/x86/hvm/hvm.c:5003: regs->_eax = -ENOSYS; /* PVH 32bitfixme. */ > arch/x86/hvm/vmx/vmcs.c:987: /* Start in 64-bit mode. PVH > 32bitfixme. */ > arch/x86/hvm/vmx/vmcs.c:1128: /* CS.L == 1, exec, read/write, > accessed. PVH 32bitfixme. */ OK, so "git grep -i pvh.*fixme" (with an extra *) is closer to the canonical list, thanks. (and it seems that at least some of these come other under feature work anyway, like 32 bit or amd support). Ian.