From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Borislav Petkov <bp@suse.de>,
Mark Rustad <mark.d.rustad@intel.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH v9 1/3] x86/setup: introduce setup_bultin_cmdline
Date: Wed, 03 Jun 2015 12:30:12 +0300 [thread overview]
Message-ID: <1433323812.26331.43.camel@linux.intel.com> (raw)
In-Reply-To: <1433318116-7061-1-git-send-email-kuleshovmail@gmail.com>
On Wed, 2015-06-03 at 13:55 +0600, Alexander Kuleshov wrote:
> This patch introduces the setup_builtin_cmdline function which appends or
> overrides boot_command_line with the builtin_cmdline if CONFIG_CMDLINE_BOOL
> is set.
> Previously this functional was in the setup_arch, but we need to move
> it for getting actual command line as early as possible in the
> arch/x86/kernel/head{32,64}.c for the earlyprintk setup.
[]
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -733,7 +733,7 @@ static void __init trim_snb_memory(void)
> * already been reserved.
> */
> memblock_reserve(0, 1<<20);
> -
> +
> for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
> if (memblock_reserve(bad_pages[i], PAGE_SIZE))
> printk(KERN_WARNING "failed to reserve 0x%08lx\n",
> @@ -825,7 +825,7 @@ static void __init trim_low_memory_range(void)
> {
> memblock_reserve(0, ALIGN(reserve_low, PAGE_SIZE));
> }
> -
> +
> /*
> * Dump out kernel offset information on panic.
> */
You again mixed things in one patch. Style thing if you wish shall go
separately.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-06-03 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 7:54 [PATCH v9 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible Alexander Kuleshov
2015-06-03 7:55 ` [PATCH v9 1/3] x86/setup: introduce setup_bultin_cmdline Alexander Kuleshov
2015-06-03 9:30 ` Andy Shevchenko [this message]
2015-06-05 7:51 ` Alexander Kuleshov
2015-06-05 10:47 ` Andy Shevchenko
2015-06-05 7:58 ` Alexander Kuleshov
2015-06-03 7:55 ` [PATCH v9 2/3] x86/setup: handle builtin command line as early as possible Alexander Kuleshov
2015-06-03 7:55 ` [PATCH v9 3/3] x86/earlyprintk: setup earlyprintk " Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433323812.26331.43.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.