Re: [PATCH v2] tools: link executables with libtinfo explicitly

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2015-06-02 at 17:58 +0100, Wei Liu wrote:
> On Tue, Jun 02, 2015 at 03:33:26PM +0200, Daniel Kiper wrote:
> > binutils 2.22 changed ld default from --copy-dt-needed-entries
> > to -no-copy-dt-needed-entries. This revealed that some objects
> > are linked implicitly with libtinfo and newer ld fails to build
> > relevant executables.

For future reference "relevant executables" would be better as a list of
the actual affected programs...

> > 
> > Below is short explanation why we should not do that...
> > 
> > http://fedoraproject.org/wiki/UnderstandingDSOLinkChange says:
> > 
> > The default behaviour for ld (my note: before version 2.22) allows
> > users to 'indirectly' link to required objects/libraries through
> > intermediate objects/libraries. While this is convenient, it can
> > also be dangerous because it makes your program's dependencies tied
> > to the dependencies of other objects. If those objects ever change
> > their linkages, they can break your program without any changes
> > to your own code!
> > 
> > Please run autoconf in tools directory.
> > 
> > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Applied, running autoconf.

Ian.