All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Hodaszi, Robert" <robert.hodaszi@digi.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"royujjal@gmail.com" <royujjal@gmail.com>
Subject: Re: [PATCH] cfg80211: modify lower retry limit to 0
Date: Wed, 03 Jun 2015 16:52:26 +0200	[thread overview]
Message-ID: <1433343146.2274.17.camel@sipsolutions.net> (raw)
In-Reply-To: <1433337281.7119.38.camel@A1-HR-PC>

On Wed, 2015-06-03 at 13:14 +0000, Hodaszi, Robert wrote:
> The problem is if I change the rt2800 driver to set 0 if it gets 1,
> etc., that will break all existing user-space programs.

Well, I guess it's a question of which userspace even uses it, and how
it'll break.

Perhaps we should modify the wext userspace API to allow 0-254, and add
1 to the value before passing it to the driver. That way, in wext it
would be "compatible" with your expected behaviour, but internally we'd
still use the 802.11 semantics. I'd accept a patch doing this, since
you're the only one to ever even admit to using it (and still using
wext) :-)

Of course we should also fix the driver to treat it as # of transmission
attempts rather than # of retries, since clearly that's required for the
nl80211 API which is documented to do it like the spec.

johannes


      reply	other threads:[~2015-06-03 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 12:46 [PATCH] cfg80211: modify lower retry limit to 0 Robert Hodaszi
2015-06-03 13:05 ` Johannes Berg
2015-06-03 13:14   ` Hodaszi, Robert
2015-06-03 14:52     ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433343146.2274.17.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robert.hodaszi@digi.com \
    --cc=royujjal@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.