From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v1 COLO Pre 03/12] tools/libxc: export xc_bitops.h Date: Thu, 4 Jun 2015 09:36:38 +0100 Message-ID: <1433406998.7108.86.camel@citrix.com> References: <1433237180-21181-1-git-send-email-yanghy@cn.fujitsu.com> <1433237180-21181-4-git-send-email-yanghy@cn.fujitsu.com> <556D814A.7090909@citrix.com> <556FA381.6070300@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <556FA381.6070300@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, Andrew Cooper , yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-06-04 at 09:01 +0800, Yang Hongyang wrote: > > On 06/02/2015 06:11 PM, Andrew Cooper wrote: > > On 02/06/15 10:26, Yang Hongyang wrote: > >> When we are under COLO, we will send dirty page bitmap info from > >> secondary to primary at every checkpoint. So we need to get/test > >> the dirty page bitmap. We just expose xc_bitops.h for libxl use. > >> > >> NOTE: > >> Need to make clean and rerun configure to get it compiled. > >> > >> Signed-off-by: Yang Hongyang > > > > I like this change, but lets take the opportunity to fix some of the > > issues in it. > > Thanks, will fix in next version. Please do fix and move in two separate patches, probably fix first although I don't mind overall. Ian.