From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xen/sched_rt: Use the correct type for _cpumask_scratch Date: Thu, 4 Jun 2015 10:57:23 +0200 Message-ID: <1433408243.2745.19.camel@citrix.com> References: <1433257664-25570-1-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8089610029200450302==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z0Qxv-0005hg-TL for xen-devel@lists.xenproject.org; Thu, 04 Jun 2015 08:57:32 +0000 In-Reply-To: <1433257664-25570-1-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: George Dunlap , xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org --===============8089610029200450302== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-GMYvjhqTuJSHwLG1rdYM" --=-GMYvjhqTuJSHwLG1rdYM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-06-02 at 16:07 +0100, Julien Grall wrote: > The commit 376bbbabbda607d2039b8f839f15ff02721597d2 "sched_rt: print usef= ul > affinity info when dumping" breaks build on ARM64: >=20 > sched_rt.c: In function =E2=80=98rt_init=E2=80=99: > sched_rt.c:442:26: error: assignment from incompatible pointer type [-Wer= ror] > _cpumask_scratch =3D xmalloc_array(cpumask_var_t, nr_cpu_ids); > ^ > sched_rt.c: In function =E2=80=98rt_alloc_pdata=E2=80=99: > sched_rt.c:489:29: error: passing argument 1 of =E2=80=98alloc_cpumask_va= r=E2=80=99 from incompatible pointer type [-Werror] > if ( !alloc_cpumask_var(&_cpumask_scratch[cpu]) ) >=20 > This is because cpumask_var_t is not a type alias to cpumask_t** when > the number of CPU > 2 * BITS_PER_LONG. The correct type for > _cpumask_scratch should be cpumask_var_t. >=20 Oh, right. Sorry for this, I didn't have an ARM build test sat up when working on this patch and, although now I have it, I did not run it through it when resending the patch (although, this is probably not only ARM related!). Sorry also for not replying to this promptly, I was on leave until today (good that this has been picked already anyway :-)). Dario --=-GMYvjhqTuJSHwLG1rdYM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlVwEvMACgkQk4XaBE3IOsT5MQCfRj31e1xAbsHI+MCOl/eYukRe w0kAoIPkVxlmB73DQNP98jvOkkOn55OW =zsHk -----END PGP SIGNATURE----- --=-GMYvjhqTuJSHwLG1rdYM-- --===============8089610029200450302== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8089610029200450302==--