From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: RFC: QEMU bumping memory limit and domain restore Date: Thu, 4 Jun 2015 10:46:17 +0100 Message-ID: <1433411177.7108.93.camel@citrix.com> References: <20150602140507.GM19403@zion.uk.xensource.com> <20150604091411.GF12468@zion.uk.xensource.com> <1433409984.7108.90.camel@citrix.com> <55701B15.9060007@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z0RjC-00005n-9N for xen-devel@lists.xenproject.org; Thu, 04 Jun 2015 09:46:22 +0000 In-Reply-To: <55701B15.9060007@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Wei Liu , Stefano Stabellini , George Dunlap , Ian Jackson , Don Slutz , andrew@zion.uk.xensource.com, xen-devel , Yang Hongyang List-Id: xen-devel@lists.xenproject.org On Thu, 2015-06-04 at 10:32 +0100, Andrew Cooper wrote: > On 04/06/15 10:26, Ian Campbell wrote: > > On Thu, 2015-06-04 at 10:14 +0100, Wei Liu wrote: > >> The main objection is that we shouldn't call xc_domain_setmaxmem in the > >> middle of a migration stream. > > In the middle of an _xc_ migration stream. > > > > This seems like the sort of thing it would be OK to have in a (to be > > introduced) libxl stream (which would itself contain the xc stream as a > > data item). > > > > I think we are expecting such a thing to be introduced as part of the > > libxl side of migration v2, aren't we? > > No. libxl migration v2 will not be affecting the behaviour here. By "such a thing" I was referring to "a libxl stream format", not this piece of data specifically. This stream format however will be extensible (I hope) and therefore could accommodate state information which differs from the domain configuration. > The only reasonable way I see this being fixed is for the libxl json > blob For _a_ libxl json blob, not necessarily the existing one, which is the user's domain configuration information. IOW it doesn't have to be the existing libxl_domain_config blob. (Nor does it really need to be json, but whatever) > to contain the correct size of the VM, and for > libxl_domain_create() to make an appropriately sized VM in the first place. > > One extension which libxl migration v2 will bring is the ability to send > a new json blob later in the stream, but such a fix still requires the > json blob to have the correct size in it. > > ~Andrew