From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 for Xen 4.6 1/4] xen: enabling XL to set per-VCPU parameters of a domain for RTDS scheduler Date: Thu, 4 Jun 2015 17:10:09 +0200 Message-ID: <1433430609.6291.13.camel@citrix.com> References: <1432598752-20826-1-git-send-email-chong.li@wustl.edu> <1432907462.5077.42.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4172751953344495464==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chong Li Cc: Chong Li , Sisu Xi , George Dunlap , xen-devel , Meng Xu , Jan Beulich , Dagaen Golomb List-Id: xen-devel@lists.xenproject.org --===============4172751953344495464== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-2EEDiQNIzS3NJvi9Y5ow" --=-2EEDiQNIzS3NJvi9Y5ow Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-05-29 at 11:47 -0500, Chong Li wrote: > On Fri, May 29, 2015 at 8:51 AM, Dario Faggioli > wrote: > > On Mon, 2015-05-25 at 19:05 -0500, Chong Li wrote: > > > >> diff --git a/xen/common/domctl.c b/xen/common/domctl.c > >> index 28aea55..8143c44 100644 > >> --- a/xen/common/domctl.c > >> +++ b/xen/common/domctl.c >=20 > > > > /* Set or get info? */ > > #define XEN_DOMCTL_SCHEDOP_putinfo 0 > > #define XEN_DOMCTL_SCHEDOP_getinfo 1 > > #define XEN_DOMCTL_SCHEDOP_putvcpuinfo 2 > > #define XEN_DOMCTL_SCHEDOP_getvcpuinfo 3 > > struct xen_domctl_scheduler_op { > > uint32_t sched_id; /* XEN_SCHEDULER_* */ > > uint32_t cmd; /* XEN_DOMCTL_SCHEDOP_* */ > > union { > > xen_domctl_schedparam_t d; > > struct { > > XEN_GUEST_HANDLE_64(xen_domctl_schedparam_vcpu_t) vcpus; > > uint16_t nr_vcpus; > > } v; > > } u; > > }; > > typedef struct xen_domctl_scheduler_op xen_domctl_scheduler_op_t; > > DEFINE_XEN_GUEST_HANDLE(xen_domctl_scheduler_op_t); > > > > I'm also attaching a (build-tested only) patch to that effect (I'm > > killing SEDF in there, so I don't have to care about it, as it's going > > away anyway). > > > > Thoughts? > > > I see. So now we put per-dom params and per-vcpu params into the same > structure (xen_domctl_scheduler_op). This structure will be handled in > sched_adjust and there should be a "switch" in that function to > distinguish per-dom get/set and per-vcpu get/set. Right? >=20 You're describing correctly what I had in mind and tried to do in the draft patch, yes. Whether to do it or not, well, it's a proposal. George says he also thinks the thing makes sense to him too, so I guess you can go ahead and try doing so in v3. Of course, others, feel free to chime in. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-2EEDiQNIzS3NJvi9Y5ow Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlVwalEACgkQk4XaBE3IOsRUuQCdE5cUVe3nhRE5zswYau6RK6/e YdAAn00tOa5fSXT47o4GRO6gor9nMF/y =NO6Q -----END PGP SIGNATURE----- --=-2EEDiQNIzS3NJvi9Y5ow-- --===============4172751953344495464== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4172751953344495464==--