All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Don Slutz <dslutz@verizon.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>,
	Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Eddie Dong <eddie.dong@intel.com>,
	xen-devel@lists.xen.org,
	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH v11 3/9] tools: Add vmware_hwver support
Date: Thu, 4 Jun 2015 16:17:08 +0100	[thread overview]
Message-ID: <1433431028.7108.117.camel@citrix.com> (raw)
In-Reply-To: <1432309826-6420-4-git-send-email-dslutz@verizon.com>

On Fri, 2015-05-22 at 11:50 -0400, Don Slutz wrote:
> [...] 
> +=item B<vmware_hwver=NUMBER>
> +
> +Turns on or off the exposure of VMware cpuid.  The number is
> +VMware's hardware version number, where 0 is off.  A number >= 7
> +is needed to enable exposure of VMware cpuid.
> +
> +The hardware version number (vmware_hwver) come from VMware config files.

"comes"

> diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
> index 38d065f..4362d5d 100644
> --- a/tools/libxc/xc_domain.c
> +++ b/tools/libxc/xc_domain.c
> @@ -64,7 +64,7 @@ int xc_domain_create(xc_interface *xch,
>      memset(&config, 0, sizeof(config));
>  
>  #if defined (__i386) || defined(__x86_64__)
> -    /* No arch-specific configuration for now */
> +    /* No arch-specific default configuration for now */

I'm not sure this hunk has anything to do with this patch, nor what the
semantic difference between the old and new text is supposed to be.

Ian.

  parent reply	other threads:[~2015-06-04 15:17 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 15:50 [PATCH v11 0/9] Xen VMware tools support Don Slutz
2015-05-22 15:50 ` [PATCH v11 1/9] tools: Add vga=vmware Don Slutz
2015-05-22 15:50 ` [PATCH v11 2/9] xen: Add support for VMware cpuid leaves Don Slutz
2015-05-22 15:50 ` [PATCH v11 3/9] tools: Add vmware_hwver support Don Slutz
2015-06-03 14:53   ` George Dunlap
2015-06-04 15:15     ` Ian Campbell
2015-06-04 15:46       ` Don Slutz
2015-06-04 15:17   ` Ian Campbell [this message]
2015-06-04 15:59     ` Don Slutz
2015-05-22 15:50 ` [PATCH v11 4/9] vmware: Add VMware provided include file Don Slutz
2015-05-22 15:50 ` [PATCH v11 5/9] xen: Add vmware_port support Don Slutz
2015-06-05  9:52   ` Jan Beulich
2015-06-05 13:18     ` Don Slutz
2015-05-22 15:50 ` [PATCH v11 6/9] xen: Add ring 3 " Don Slutz
2015-06-03 15:26   ` George Dunlap
2015-06-03 15:58     ` Andrew Cooper
2015-06-03 16:23       ` George Dunlap
2015-06-03 16:40         ` Andrew Cooper
2015-06-03 17:00           ` George Dunlap
2015-06-03 16:41         ` Don Slutz
2015-06-03 16:58           ` George Dunlap
2015-06-04 12:37             ` Don Slutz
2015-06-04 14:14               ` George Dunlap
2015-06-04 16:17                 ` Don Slutz
2015-06-03 16:36       ` Don Slutz
2015-06-03 16:50         ` George Dunlap
2015-06-05  9:31           ` Jan Beulich
2015-06-05 10:54             ` Ian Campbell
2015-06-11 22:10               ` Don Slutz
2015-06-12  6:25                 ` Jan Beulich
2015-06-12 12:52                   ` Don Slutz
2015-06-23 16:14   ` Jan Beulich
2015-06-26 14:54     ` Don Slutz
2015-05-22 15:50 ` [PATCH v11 7/9] tools: Add " Don Slutz
2015-06-03 17:06   ` George Dunlap
2015-06-04 15:49     ` Ian Campbell
2015-06-04 16:09       ` Don Slutz
2015-06-04 15:20   ` Ian Campbell
2015-05-22 15:50 ` [PATCH v11 8/9] Add IOREQ_TYPE_VMWARE_PORT Don Slutz
2015-06-03 17:09   ` George Dunlap
2015-06-04 11:28     ` Don Slutz
2015-06-05  9:35       ` Jan Beulich
2015-06-05 10:03         ` Paul Durrant
2015-06-08 10:05       ` George Dunlap
2015-06-11 21:51         ` Don Slutz
2015-05-22 15:50 ` [PATCH v11 9/9] Add xentrace to vmware_port Don Slutz
2015-06-04 11:20   ` George Dunlap
2015-06-04 12:31     ` Don Slutz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433431028.7108.117.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Aravind.Gopalakrishnan@amd.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dslutz@verizon.com \
    --cc=eddie.dong@intel.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir@xen.org \
    --cc=kevin.tian@intel.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.