From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v11 7/9] tools: Add vmware_port support Date: Thu, 4 Jun 2015 16:49:13 +0100 Message-ID: <1433432953.7108.122.camel@citrix.com> References: <1432309826-6420-1-git-send-email-dslutz@verizon.com> <1432309826-6420-8-git-send-email-dslutz@verizon.com> <556F33FE.4070700@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <556F33FE.4070700@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Tim Deegan , Kevin Tian , Keir Fraser , Jun Nakajima , Stefano Stabellini , Ian Jackson , Eddie Dong , Don Slutz , xen-devel@lists.xen.org, Aravind Gopalakrishnan , Jan Beulich , Andrew Cooper , Boris Ostrovsky , Suravee Suthikulpanit List-Id: xen-devel@lists.xenproject.org On Wed, 2015-06-03 at 18:06 +0100, George Dunlap wrote: > On 05/22/2015 04:50 PM, Don Slutz wrote: > > This new libxl_domain_create_info field is used to set > > XEN_DOMCTL_CONFIG_VMWARE_PORT_MASK in the xc_domain_configuration_t > > for x86. > > > > In xen it is is_vmware_port_enabled. > > > > If is_vmware_port_enabled then > > enable a limited support of VMware's hyper-call. > > > > VMware's hyper-call is also known as VMware Backdoor I/O Port. > > > > if vmware_port is not specified in the config file, let > > "vmware_hwver != 0" be the default value. This means that only > > vmware_hwver = 7 needs to be specified to enable both features. > > > > vmware_hwver = 7 is special because that is what controls the > > enable of CPUID leaves for VMware (vmware_hwver >= 7). > > > > Note: vmware_port and nestedhvm cannot be specified at the > > same time. > > > > Signed-off-by: Don Slutz > > Ian: > > So I *think* it may be the case that this patch only depends on patch 5 > to apply. I also think that patches 5 and 7 together add another useful > "chunk" of functionality (core vmport functionality for guest OSes). Is there any point in this chunk without 1..3?